Skip to content

Commit

Permalink
Fixed #2846
Browse files Browse the repository at this point in the history
moved the test Class to a new package
changed the instance variable name (b to browser)
added the package to the baseline
  • Loading branch information
GDayne committed Jul 26, 2019
1 parent 7600dd5 commit 444834b
Show file tree
Hide file tree
Showing 4 changed files with 109 additions and 111 deletions.
118 changes: 56 additions & 62 deletions src/BaselineOfBasicTools/BaselineOfBasicTools.class.st
Expand Up @@ -30,71 +30,65 @@ Class {
}

{ #category : #baseline }
BaselineOfBasicTools >> baseline: spec [

BaselineOfBasicTools >> baseline: spec [
<baseline>

| repository |

| repository |
repository := self packageRepositoryURL.
spec
for: #common
do: [ spec postLoadDoIt: #postload:package:.

spec for: #common do: [
spec postLoadDoIt: #'postload:package:'.

"Load first SUnit core"
spec
baseline: 'SUnitCore' with: [
spec
loads: 'Core';
className: 'BaselineOfSUnit';
repository: repository ].
spec
baseline: 'UI' with: [spec repository: repository];
baseline: 'Athens' with: [
spec
loads: 'Cairo-core';
repository: repository ];
baseline: 'SUnit' with: [
spec
loads: #('UI' 'Help' 'JenkinsSupport');
repository: repository ].

spec package: 'Tool-ExternalBrowser'.
spec package: 'BlueInk-Core'.
spec package: 'BlueInk-Extras'.
spec package: 'Tool-ProcessBrowser'.
spec package: 'Tool-Profilers'.
spec package: 'Tool-SystemReporter'.
spec package: 'NECompletion'.

spec package: 'Announcements-Help'.
spec package: 'Metacello-FileTree'.
spec package: 'Metacello-Cypress'.
spec package: 'Metacello-ProfStef'.
spec package: 'Metacello-Reference'.
spec package: 'Metacello-Tutorial'.
spec package: 'MonticelloGUI'.
spec package: 'Network-Mail'.
spec package: 'Pharo-Help'.
spec package: 'ProfStef-Core'.
spec package: 'ProfStef-Help'.
spec package: 'RecentSubmissions'.
spec package: 'Refactoring-Changes'.
spec package: 'Refactoring-Core'.
spec package: 'Refactoring-Environment'.
spec package: 'Regex-Help'.
spec package: 'IssueTracking'.
spec package: 'Monticello-OldDataStreamCompatibility'.
spec package: 'MonticelloFileServices'.
spec package: 'Spec-Help'.
spec package: 'Spec2-Help'.
spec package: 'Tool-Diff'.
spec package: 'Tool-FileList'.
spec package: 'Tool-Finder'.
spec package: 'Tool-ImageCleaner'.
spec package: 'Tools'.

].
"Load first SUnit core"
spec
baseline: 'SUnitCore'
with: [ spec
loads: 'Core';
className: 'BaselineOfSUnit';
repository: repository ].
spec
baseline: 'UI' with: [ spec repository: repository ];
baseline: 'Athens'
with: [ spec
loads: 'Cairo-core';
repository: repository ];
baseline: 'SUnit'
with: [ spec
loads: #('UI' 'Help' 'JenkinsSupport');
repository: repository ].
spec package: 'Tool-ExternalBrowser'.
spec package: 'BlueInk-Core'.
spec package: 'BlueInk-Extras'.
spec package: 'Tool-ProcessBrowser'.
spec package: 'Tool-Profilers'.
spec package: 'Tool-SystemReporter'.
spec package: 'NECompletion'.
spec package: 'Announcements-Help'.
spec package: 'Metacello-FileTree'.
spec package: 'Metacello-Cypress'.
spec package: 'Metacello-ProfStef'.
spec package: 'Metacello-Reference'.
spec package: 'Metacello-Tutorial'.
spec package: 'MonticelloGUI'.
spec package: 'MonticelloGUI-Tests'.
spec package: 'Network-Mail'.
spec package: 'Pharo-Help'.
spec package: 'ProfStef-Core'.
spec package: 'ProfStef-Help'.
spec package: 'RecentSubmissions'.
spec package: 'Refactoring-Changes'.
spec package: 'Refactoring-Core'.
spec package: 'Refactoring-Environment'.
spec package: 'Regex-Help'.
spec package: 'IssueTracking'.
spec package: 'Monticello-OldDataStreamCompatibility'.
spec package: 'MonticelloFileServices'.
spec package: 'Spec-Help'.
spec package: 'Spec2-Help'.
spec package: 'Tool-Diff'.
spec package: 'Tool-FileList'.
spec package: 'Tool-Finder'.
spec package: 'Tool-ImageCleaner'.
spec package: 'Tools' ]
]

{ #category : #actions }
Expand Down
52 changes: 52 additions & 0 deletions src/MonticelloGUI-Tests/MCWorkingCopyBrowserTest.class.st
@@ -0,0 +1,52 @@
"
This class is testing Monticello initialization
"
Class {
#name : #MCWorkingCopyBrowserTest,
#superclass : #TestCase,
#instVars : [
'browser'
],
#category : #'MonticelloGUI-Tests'
}

{ #category : #running }
MCWorkingCopyBrowserTest >> setUp [
super setUp.
browser := MCWorkingCopyBrowser new.
]

{ #category : #tests }
MCWorkingCopyBrowserTest >> testDefault [
"When opened, there are plenty of packages, ie., working copies that are listed"
self assert: browser workingCopies notNil.
self assert: browser workingCopies notEmpty.

"When opening, there is no repository selected"
self assert: browser repository isNil.

"No repository is selected"
self assert: browser repositorySelection equals: 0
]

{ #category : #tests }
MCWorkingCopyBrowserTest >> testRepositories [
self assert: browser repositories notNil.
self assert: browser repositories notEmpty.
self assert: browser repositoryGroup notNil.
self assert: browser repositoryGroup repositories size equals: browser repositories size.
]

{ #category : #tests }
MCWorkingCopyBrowserTest >> testRepositoriesIncludeCache [
"At least one cache is present in the list of repositories"
self assert: (browser repositories anySatisfy: [ :r | r class == MCCacheRepository ])
]

{ #category : #tests }
MCWorkingCopyBrowserTest >> testRepositoryList [
self assert: browser repositoryList notNil.
self assert: browser repositoryList notEmpty.
self assert: browser repositoryList size equals: browser repositories size.
self assert: (browser repositoryList allSatisfy: [ :r | r isString ]).
]
1 change: 1 addition & 0 deletions src/MonticelloGUI-Tests/package.st
@@ -0,0 +1 @@
Package { #name : #'MonticelloGUI-Tests' }
49 changes: 0 additions & 49 deletions src/MonticelloGUI/MCWorkingCopyBrowserTest.class.st

This file was deleted.

0 comments on commit 444834b

Please sign in to comment.