ReReferencesObsoleteClassRule, fix ReGlobalVariablesUsageRule as it w…

…as wrongly detecting

src/GeneralRules/ReGlobalVariablesUsageRule.class.st

@@ -21,7 +21,8 @@ ReGlobalVariablesUsageRule >> check: aMethod forCritiquesDo: aCriticBlock [
 			node isVariable and: [ 
 				node variable isGlobalVariable and: [
 					(self isKnownGlobal: node name) not and: [
-						node variable isGlobalClassNameBinding not ] ] ] ]
+						node variable value isObsolete not and: [
+							node variable isGlobalClassNameBinding not ] ] ] ] ]
 		thenDo: [ :node |
 			aCriticBlock cull: (self
 				createTrivialCritiqueOn: aMethod

src/GeneralRules/ReReferencesObsoleteClassRule.class.st

@@ -0,0 +1,40 @@
+"
+You are referencing a class that is obsolete, that is, it has been removed
+
+"
+Class {
+	#name : #ReReferencesObsoleteClassRule,
+	#superclass : #ReNodeBasedRule,
+	#category : #'GeneralRules-Migrated'
+}
+
+{ #category : #helpers }
+ReReferencesObsoleteClassRule >> basicCheck: aNode [
+ 	^ aNode isVariable 
+ 		and: [aNode isGlobal
+			"we can not use isGlobalClassNameBinding here"
+ 			and: [ aNode variable value isClassOrTrait
+ 				and: [ aNode variable value isObsolete ] ] ]
+]
+
+{ #category : #helpers }
+ReReferencesObsoleteClassRule >> critiqueFor: aNode [
+	^ (super critiqueFor: aNode)
+		  tinyHint: aNode name;
+		  yourself
+]
+
+{ #category : #accessing }
+ReReferencesObsoleteClassRule >> group [
+	^ 'Bugs'
+]
+
+{ #category : #accessing }
+ReReferencesObsoleteClassRule >> name [
+	^ 'References an obsolete class'
+]
+
+{ #category : #accessing }
+ReReferencesObsoleteClassRule >> severity [
+	^ #error
+]