tests failures fixed

pharo-project · May 25, 2018 · 4f18c7c · 4f18c7c
1 parent e965882
commit 4f18c7c
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 31 deletions.
diff --git a/src/Kernel-Tests/BehaviorTest.class.st b/src/Kernel-Tests/BehaviorTest.class.st
@@ -238,26 +238,6 @@ BehaviorTest >> testWhichSelectorsAccess [
 	self deny:  ((Point whichSelectorsAccess: 'y') includes: #x).
 ]
 
-{ #category : #tests }
-BehaviorTest >> testWhichSelectorsAccessFindSlots [
-	| cls |
-	cls := Object newAnonymousSubclass.
-	cls := cls addSlot: #regularIvar.
-	cls := cls addSlot: #slotIvar => PropertySlot.
-	cls
-		compile:
-			'initialize 
-		super initialize.
-	
-		regularIvar := 4.
-		slotIvar := 2.
-	'.
-	self
-		assert: (cls whichSelectorsAccess: #regularIvar) size equals: 1;
-		assert: (cls whichSelectorsAccess: #slotIvar) size equals: 1;
-		assert: (cls whichSelectorsAccess: #notAnIvar) equals: #()
-]
-
 { #category : #tests }
 BehaviorTest >> testallSuperclassesIncluding [
 

diff --git a/src/Slot-Tests/PropertySlotTest.class.st b/src/Slot-Tests/PropertySlotTest.class.st
@@ -141,3 +141,23 @@ PropertySlotTest >> testRemovePropertySlot2 [
 	self deny: 	(aClass hasSlot: propertySlot2).
 	self deny:	(aClass classLayout hasSlotNamed:  #'_propertyBaseSlot'). 
 ]
+
+{ #category : #tests }
+PropertySlotTest >> testWhichSelectorsAccessFindSlots [
+	| cls |
+	cls := Object newAnonymousSubclass.
+	cls := cls addSlot: #regularIvar.
+	cls := cls addSlot: #slotIvar => PropertySlot.
+	cls
+		compile:
+			'initialize 
+		super initialize.
+	
+		regularIvar := 4.
+		slotIvar := 2.
+	'.
+	self
+		assert: (cls whichSelectorsAccess: #regularIvar) size equals: 1;
+		assert: (cls whichSelectorsAccess: #slotIvar) size equals: 1;
+		assert: (cls whichSelectorsAccess: #notAnIvar) equals: #()
+]
diff --git a/src/System-DependenciesTests/SystemDependenciesTest.class.st b/src/System-DependenciesTests/SystemDependenciesTest.class.st
@@ -210,7 +210,7 @@ SystemDependenciesTest >> testExternalBasicToolsDependencies [
 	dependencies := self externalDependendiesOf: (
 		self metacelloPackageNames,
 		self tonelCorePackageNames,
-		BaselineOfTraits allPackageNames,
+		BaselineOfTraits corePackages,
 		{ BaselineOfSUnit name }, BaselineOfSUnit allPackageNames, "ALL"
 		{ BaselineOfDisplay name }, BaselineOfDisplay allPackageNames,
 		{ BaselineOfUnifiedFFI name }, BaselineOfUnifiedFFI allPackageNames,
@@ -249,7 +249,7 @@ SystemDependenciesTest >> testExternalDisplayDependencies [
 	dependencies := self externalDependendiesOf: (
 		self metacelloPackageNames,
 		self tonelCorePackageNames,
-		BaselineOfTraits allPackageNames,		
+		BaselineOfTraits corePackages,		
 		BaselineOfDisplay allPackageNames).
 
 	self assertCollection: dependencies equals: self knownDisplayDependencies.
@@ -283,6 +283,7 @@ SystemDependenciesTest >> testExternalIDEDependencies [
 		self metacelloPackageNames,
 		self tonelCorePackageNames,
 		{ BaselineOfTraits name }, BaselineOfTraits allPackageNames,		
+		{ BaselineOfSlot name }, BaselineOfSlot allPackageNames,		
 		{ BaselineOfSUnit name }, BaselineOfSUnit allPackageNames, "ALL"
 		{ BaselineOfDisplay name }, BaselineOfDisplay allPackageNames,
 		{ BaselineOfUnifiedFFI name }, BaselineOfUnifiedFFI allPackageNames,
@@ -337,7 +338,7 @@ SystemDependenciesTest >> testExternalMetacelloDependencies [
 
 	self longTestCase.
 
-	dependencies := self externalDependendiesOf: self metacelloPackageNames, BaselineOfTraits allPackageNames.
+	dependencies := self externalDependendiesOf: self metacelloPackageNames, BaselineOfTraits corePackages.
 
 	self assertCollection: dependencies equals: self knownMetacelloDependencies.
 ]
@@ -350,7 +351,7 @@ SystemDependenciesTest >> testExternalMonticelloDependencies [
 	self longTestCase.
 
 	dependencies := self externalDependendiesOf: (
-		BaselineOfTraits allPackageNames,		
+		BaselineOfTraits corePackages,		
 		BaselineOfPharoBootstrap kernelPackageNames,
 		BaselineOfPharoBootstrap multilingualPackageNames,
 		BaselineOfPharoBootstrap compilerPackageNames,
@@ -372,7 +373,7 @@ SystemDependenciesTest >> testExternalMorphicCoreDependencies [
 	dependencies := self externalDependendiesOf: (
 		self metacelloPackageNames,
 		self tonelCorePackageNames,
-		BaselineOfTraits allPackageNames,			
+		BaselineOfTraits corePackages,			
 		BaselineOfSUnit defaultPackageNames,
 		BaselineOfDisplay allPackageNames,
 		BaselineOfUnifiedFFI allPackageNames,
@@ -391,7 +392,7 @@ SystemDependenciesTest >> testExternalMorphicDependencies [
 	dependencies := self externalDependendiesOf: (
 		self metacelloPackageNames,
 		self tonelCorePackageNames,
-		BaselineOfTraits allPackageNames,		
+		BaselineOfTraits corePackages,		
 		BaselineOfSUnit defaultPackageNames,
 		BaselineOfDisplay allPackageNames,
 		BaselineOfUnifiedFFI allPackageNames,
@@ -409,7 +410,7 @@ SystemDependenciesTest >> testExternalSUnitDependencies [
 	self longTestCase.
 
 	dependencies := self externalDependendiesOf: (
-		BaselineOfTraits allPackageNames,			
+		BaselineOfTraits corePackages,			
 		self metacelloPackageNames,
 		self tonelCorePackageNames,
 		BaselineOfSUnit defaultPackageNames).
@@ -425,7 +426,7 @@ SystemDependenciesTest >> testExternalSUnitKernelDependencies [
 	self longTestCase.
 
 	dependencies := self externalDependendiesOf: (
-		BaselineOfTraits allPackageNames,
+		BaselineOfTraits corePackages,
 		BaselineOfPharoBootstrap kernelPackageNames,
 		BaselineOfPharoBootstrap multilingualPackageNames,
 		BaselineOfPharoBootstrap kernelAdditionalPackagesNames,
@@ -443,7 +444,7 @@ SystemDependenciesTest >> testExternalSpecDependencies [
 
 	dependencies := (self externalDependendiesOf: (
 			self metacelloPackageNames,
-			BaselineOfTraits allPackageNames,			
+			BaselineOfTraits corePackages,			
 			self specPackageNames )) 
 		copyWithoutAll: self knownMetacelloDependencies.
 
@@ -460,7 +461,7 @@ SystemDependenciesTest >> testExternalUFFIDependencies [
 	dependencies := self externalDependendiesOf: (
 		self metacelloPackageNames,
 		self tonelCorePackageNames,
-		BaselineOfTraits allPackageNames,				
+		BaselineOfTraits corePackages,				
 		BaselineOfSUnit defaultPackageNames,
 		BaselineOfUnifiedFFI allPackageNames).
 
@@ -477,7 +478,7 @@ SystemDependenciesTest >> testExternalUIDependencies [
 	dependencies := (self externalDependendiesOf: (
 		self metacelloPackageNames,
 		self tonelCorePackageNames,
-		BaselineOfTraits allPackageNames,
+		BaselineOfTraits corePackages,
 		BaselineOfSUnit defaultPackageNames,
 		BaselineOfDisplay allPackageNames,
 		BaselineOfUnifiedFFI allPackageNames,