There where quite some rules just kept around for the old "Monkey" (t…

…he CI checker before we moved to git) The classes where just wrappers of other rules with notes like that: self flag: 'The functionality was moved to TemporaryNeitherReadNorWrittenRule, but as this rule is used by Monkey
pharo-project · Jul 12, 2020 · 6a47c77 · 6a47c77
1 parent ab58204
commit 6a47c77
Show file tree

Hide file tree

Showing 7 changed files with 4 additions and 185 deletions.
diff --git a/src/Refactoring-Critics/PharoCriticRules.class.st b/src/Refactoring-Critics/PharoCriticRules.class.st
@@ -11,34 +11,26 @@ Class {
 PharoCriticRules class >> pharoHardLintRules [
 	"These rules are used by the CI monkey to check code before its integration into Pharo"
 	^ { 
-		RBUndeclaredReferenceRule.
+		ReUndeclaredVariableRule.
 		ReDefinesEqualNotHashRule.
 		ReEquivalentSuperclassMethodsRule.
 		ReJustSendsSuperRule.
 		ReSubclassResponsibilityNotDefinedRule.
 		"RBTempVarOverridesInstVarRule. gotta wait for a fix"
-		RBVariableNotDefinedRule.
+		ReUndeclaredVariableRule.
 		ReEqualNotUsedRule.
-		RBOnlyReadOrWrittenTemporaryRule.
+		ReTemporaryNeitherReadNorWrittenRule.
 		RePrecedenceRule.
 		SendsDeprecatedMethodToGlobalRule.
 		ReSizeCheckRule.
 		ReUnconditionalRecursionRule.
 		ReUnoptimizedToDoRule.
 		ReBetweenAndRule.
 		ReCodeCruftLeftInMethodsRule.
-		RBPharoBootstrapRule
+		PharoBootstrapRule
 	}
 ]
 
-{ #category : #accessing }
-PharoCriticRules class >> pharoIntegrationLintRule [
-	"A set of rules used by the CI monkey to check code before its integration into Pharo"
-	^ (RBCompositeLintRule rules: (self pharoHardLintRules collect: [:each | each new]))
-		name: 'Pharo integration rules';
-		yourself
-]
-
 { #category : #'default rules' }
 PharoCriticRules class >> pharoSoftLintRules [	
 	"skiped for now"

diff --git a/src/Refactoring-Critics/RBArchitectureLintRule.class.st b/src/Refactoring-Critics/RBArchitectureLintRule.class.st
diff --git a/src/Refactoring-Critics/RBOnlyReadOrWrittenTemporaryRule.class.st b/src/Refactoring-Critics/RBOnlyReadOrWrittenTemporaryRule.class.st
diff --git a/src/Refactoring-Critics/RBOnlyReadOrWrittenVariableRule.class.st b/src/Refactoring-Critics/RBOnlyReadOrWrittenVariableRule.class.st
diff --git a/src/Refactoring-Critics/RBPharoBootstrapRule.class.st b/src/Refactoring-Critics/RBPharoBootstrapRule.class.st
diff --git a/src/Refactoring-Critics/RBUndeclaredReferenceRule.class.st b/src/Refactoring-Critics/RBUndeclaredReferenceRule.class.st
diff --git a/src/Refactoring-Critics/RBVariableNotDefinedRule.class.st b/src/Refactoring-Critics/RBVariableNotDefinedRule.class.st