Care on unused ivars in Renraku

fix #7810
pharo-project · Nov 22, 2020 · 7026dd1 · 7026dd1
1 parent 08f4d50
commit 7026dd1
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 3 deletions.
diff --git a/src/GeneralRules-Tests/ReTempVarOverridesInstVarRuleTest.class.st b/src/GeneralRules-Tests/ReTempVarOverridesInstVarRuleTest.class.st
@@ -13,6 +13,26 @@ Class {
 	#category : #'GeneralRules-Tests-Migrated'
 }
 
+{ #category : #accessing }
+ReTempVarOverridesInstVarRuleTest >> dummy1 [
+	^ dummy1
+]
+
+{ #category : #accessing }
+ReTempVarOverridesInstVarRuleTest >> dummy2 [
+	^ dummy2
+]
+
+{ #category : #accessing }
+ReTempVarOverridesInstVarRuleTest >> dummy3 [
+	^ dummy3
+]
+
+{ #category : #accessing }
+ReTempVarOverridesInstVarRuleTest >> dummy4 [
+	^ dummy4
+]
+
 { #category : #'test-help' }
 ReTempVarOverridesInstVarRuleTest >> sampleMethod: dummy1 [
 	"I override dummy1, dummy2, dummy3  "

diff --git a/src/GeneralRules-Tests/ReTestCaseShouldNotUseInitializeRuleTest.class.st b/src/GeneralRules-Tests/ReTestCaseShouldNotUseInitializeRuleTest.class.st
@@ -7,6 +7,13 @@ Class {
 	#category : #'GeneralRules-Tests-Migrated'
 }
 
+{ #category : #accessing }
+ReTestCaseShouldNotUseInitializeRuleTest >> aDummyVar [
+	"Only necessary that ivar does not appear unused"
+
+	^ aDummyVar
+]
+
 { #category : #running }
 ReTestCaseShouldNotUseInitializeRuleTest >> tearDown [ 
 

diff --git a/src/Renraku/ReRemoveMethodCritique.class.st b/src/Renraku/ReRemoveMethodCritique.class.st
@@ -4,9 +4,6 @@ I am a critique that will propose to the user to remove a method.
 Class {
 	#name : #ReRemoveMethodCritique,
 	#superclass : #ReAbstractCritique,
-	#instVars : [
-		'selector'
-	],
 	#category : #'Renraku-Critiques'
 }