add rule to avoid that TestCase rely on Initialize

this pull request propose a rule to validate that users do not use initialize but setUp.
#5792

src/General-Rules-Tests/ReUseSetUpRuleTest.class.st

@@ -0,0 +1,31 @@
+Class {
+	#name : 'ReUseSetUpRuleTest',
+	#superclass : 'ReAbstractRuleTestCase',
+	#category : 'General-Rules-Tests-Migrated',
+	#package : 'General-Rules-Tests',
+	#tag : 'Migrated'
+}
+
+{ #category : 'initialization' }
+ReUseSetUpRuleTest >> initialize [ 
+]
+
+{ #category : 'tests' }
+ReUseSetUpRuleTest >> testRule [
+
+	| critiques |
+	self class compile: 'initialize'.
+	critiques := self myCritiquesOnClass: self class.
+	self assert: critiques size equals: 1.
+	[ "code of the test" ] ensure: [ (self class >> #initialize) removeFromSystem ]
+]
+
+{ #category : 'tests' }
+ReUseSetUpRuleTest >> testRuleNotViolated [ 
+
+	| critiques |
+	self class compile: 'setUp'.
+	critiques := self myCritiquesOnClass: self class.
+	self assertEmpty: critiques.
+	[ "code of the test" ] ensure: [ (self class >> #setUp) removeFromSystem ]
+]

src/General-Rules/ReUseSetUpRule.class.st

@@ -0,0 +1,53 @@
+"
+this smell arise when we use initialize instead of setUp in a TestCase
+"
+Class {
+	#name : 'ReUseSetUpRule',
+	#superclass : 'ReAbstractRule',
+	#category : 'General-Rules-Migrated',
+	#package : 'General-Rules',
+	#tag : 'Migrated'
+}
+
+{ #category : 'testing - interest' }
+ReUseSetUpRule class >> checksClass [ 
+	^ true
+]
+
+{ #category : 'manifest' }
+ReUseSetUpRule class >> uniqueIdentifierName [
+	"This number should be unique and should change only when the rule completely change semantics"
+
+	^ 'UseSetUpRule'
+]
+
+{ #category : 'running' }
+ReUseSetUpRule >> basicCheck: aClass [
+
+	aClass isTestCase ifFalse: [ ^ false ].
+	^ aClass selectors includes: #initialize
+]
+
+{ #category : 'accessing' }
+ReUseSetUpRule >> group [
+
+	^ 'Design Flaws'
+]
+
+{ #category : 'testing' }
+ReUseSetUpRule >> isRewriteRule [
+
+	^ true
+]
+
+{ #category : 'accessing' }
+ReUseSetUpRule >> name [
+
+	^ 'Uses setUp instead of initialize for Test class.'
+]
+
+{ #category : 'accessing' }
+ReUseSetUpRule >> severity [ 
+
+	^ #error
+]