Adding Reflectivity commands group (metalinks) in method context menu.

Cleanning unnecessary classes created in previous commit. Fixing root commands order in source code context menu
pharo-project · Feb 23, 2022 · a98fd30 · a98fd30
1 parent 27c16eb
commit a98fd30
Show file tree

Hide file tree

Showing 10 changed files with 54 additions and 19 deletions.
diff --git a/src/Calypso-SystemPlugins-Reflectivity-Browser/ClyReflectivityCommand.class.st b/src/Calypso-SystemPlugins-Reflectivity-Browser/ClyReflectivityCommand.class.st
@@ -36,7 +36,7 @@ ClyReflectivityCommand class >> isAbstract [
 ClyReflectivityCommand class >> methodContextMenuActivation [
 
 	<classAnnotation>
-	^ CmdContextMenuActivation 
+	^ SycReflectivityMenuActivation 
 		byItemOf: ClyReflectivityMenuGroup order: self contextMenuOrder for: ClyMethod asCalypsoItemContext
 ]
 

diff --git a/src/Calypso-SystemPlugins-Reflectivity-Browser/ClyRemoveExecutionCounterCommand.class.st b/src/Calypso-SystemPlugins-Reflectivity-Browser/ClyRemoveExecutionCounterCommand.class.st
@@ -18,6 +18,14 @@ ClyRemoveExecutionCounterCommand class >> contextMenuOrder [
 	^2
 ]
 
+{ #category : #activation }
+ClyRemoveExecutionCounterCommand class >> methodContextMenuActivation [
+
+	<classAnnotation>
+	^ SycAdvancedDebuggingMenuActivation 
+			byItemOf: ClyAdvancedDebuggingMenuGroup order: self contextMenuOrder for: ClyMethod asCalypsoItemContext
+]
+
 { #category : #activation }
 ClyRemoveExecutionCounterCommand class >> sourceCodeMenuActivation [
 	<classAnnotation>

diff --git a/src/Calypso-SystemPlugins-Reflectivity-Browser/ClyRemoveWatchCommand.class.st b/src/Calypso-SystemPlugins-Reflectivity-Browser/ClyRemoveWatchCommand.class.st
@@ -18,6 +18,14 @@ ClyRemoveWatchCommand class >> contextMenuOrder [
 	^3
 ]
 
+{ #category : #activation }
+ClyRemoveWatchCommand class >> methodContextMenuActivation [
+	<classAnnotation>
+
+	^ SycAdvancedDebuggingMenuActivation 
+			byItemOf: ClyAdvancedDebuggingMenuGroup order: self contextMenuOrder for: ClyMethod asCalypsoItemContext
+]
+
 { #category : #activation }
 ClyRemoveWatchCommand class >> sourceCodeMenuActivation [
 	<classAnnotation>

diff --git a/src/Calypso-SystemTools-Core/SycOpenAdvancedDebuggingMenuCommand.extension.st b/src/Calypso-SystemTools-Core/SycOpenAdvancedDebuggingMenuCommand.extension.st
@@ -11,5 +11,5 @@ SycOpenAdvancedDebuggingMenuCommand class >> methodEditorShortcutActivation [
 SycOpenAdvancedDebuggingMenuCommand class >> sourceCodeMenuActivation [
 	<classAnnotation>
 
-	^CmdContextMenuActivation byRootGroupItemOrder: 0 for: ClySourceCodeContext
+	^CmdContextMenuActivation byRootGroupItemOrder: 0.2 for: ClySourceCodeContext
 ]
diff --git a/src/Calypso-SystemTools-Core/SycOpenDebuggingMenuCommand.extension.st b/src/Calypso-SystemTools-Core/SycOpenDebuggingMenuCommand.extension.st
@@ -11,5 +11,5 @@ SycOpenDebuggingMenuCommand class >> methodEditorShortcutActivation [
 SycOpenDebuggingMenuCommand class >> sourceCodeMenuActivation [
 	<classAnnotation>
 
-	^CmdContextMenuActivation byRootGroupItemOrder: -1 for: ClySourceCodeContext
+	^CmdContextMenuActivation byRootGroupItemOrder: 0.2 for: ClySourceCodeContext
 ]
diff --git a/src/Calypso-SystemTools-Core/SycOpenReflectivityMenuCommand.extension.st b/src/Calypso-SystemTools-Core/SycOpenReflectivityMenuCommand.extension.st
@@ -11,5 +11,5 @@ SycOpenReflectivityMenuCommand class >> methodEditorShortcutActivation [
 SycOpenReflectivityMenuCommand class >> sourceCodeMenuActivation [
 	<classAnnotation>
 
-	^CmdContextMenuActivation byRootGroupItemOrder: 8 for: ClySourceCodeContext
+	^CmdContextMenuActivation byRootGroupItemOrder: 0.3 for: ClySourceCodeContext
 ]
diff --git a/src/SystemCommands-MethodCommands/SycAdvancedDebuggingInMethodCmCommand.class.st b/src/SystemCommands-MethodCommands/SycAdvancedDebuggingInMethodCmCommand.class.st
diff --git a/src/SystemCommands-MethodCommands/SycOpenAdvancedDebuggingInMethodMenuCommand.class.st b/src/SystemCommands-MethodCommands/SycOpenAdvancedDebuggingInMethodMenuCommand.class.st
@@ -4,7 +4,7 @@ I show in menu all commands annotated by SycAdvancedDebuggingMenuActivation
 "
 Class {
 	#name : #SycOpenAdvancedDebuggingInMethodMenuCommand,
-	#superclass : #SycOpenContextMenuCommand,
+	#superclass : #SycOpenMethodMenuCommand,
 	#category : #'SystemCommands-MethodCommands'
 }
 
@@ -20,11 +20,6 @@ SycOpenAdvancedDebuggingInMethodMenuCommand >> activationStrategy [
 	^SycAdvancedDebuggingMenuActivation
 ]
 
-{ #category : #'context menu' }
-SycOpenAdvancedDebuggingInMethodMenuCommand >> cmCommandClass [
-	^ SycAdvancedDebuggingInMethodCmCommand
-]
-
 { #category : #accessing }
 SycOpenAdvancedDebuggingInMethodMenuCommand >> defaultMenuIconName [
 	^ #smallDebug

diff --git a/src/SystemCommands-MethodCommands/SycOpenDebuggingInMethodMenuCommand.class.st b/src/SystemCommands-MethodCommands/SycOpenDebuggingInMethodMenuCommand.class.st
@@ -4,7 +4,7 @@ I show in menu all commands annotated by SycDebuggingMenuActivation
 "
 Class {
 	#name : #SycOpenDebuggingInMethodMenuCommand,
-	#superclass : #SycOpenContextMenuCommand,
+	#superclass : #SycOpenMethodMenuCommand,
 	#category : #'SystemCommands-MethodCommands'
 }
 

diff --git a/src/SystemCommands-MethodCommands/SycOpenReflectivityInMethodMenuCommand.class.st b/src/SystemCommands-MethodCommands/SycOpenReflectivityInMethodMenuCommand.class.st
@@ -0,0 +1,32 @@
+"
+I am a command to open special method menu containing metalink related commands.
+I show in menu all commands annotated by SycReflectivityMenuActivation
+"
+Class {
+	#name : #SycOpenReflectivityInMethodMenuCommand,
+	#superclass : #SycOpenMethodMenuCommand,
+	#category : #'SystemCommands-MethodCommands'
+}
+
+{ #category : #activation }
+SycOpenReflectivityInMethodMenuCommand class >> methodContextMenuActivation [
+	<classAnnotation>
+
+	^CmdContextMenuActivation byRootGroupItemOrder: 1.5 for: ClyMethod asCalypsoItemContext
+]
+
+{ #category : #execution }
+SycOpenReflectivityInMethodMenuCommand >> activationStrategy [
+	^SycReflectivityMenuActivation
+]
+
+{ #category : #accessing }
+SycOpenReflectivityInMethodMenuCommand >> defaultMenuIconName [
+	^ #smallObjects
+]
+
+{ #category : #accessing }
+SycOpenReflectivityInMethodMenuCommand >> defaultMenuItemName [
+
+	^ 'Reflectivity'
+]