unify hasSlotNamed: in AbractLayout and ClassDescription

hasSlotNamed: just checks "visible" slots, the one on AbractLayout all. We should check always all slots (visibility means just that they are not shown when you ask for a list, this is all quite crude anyway and will be generalised into a "view" concept later.) fixes #3650
pharo-project · Jun 27, 2019 · c4534c5 · c4534c5
1 parent b82e847
commit c4534c5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/Kernel/ClassDescription.class.st b/src/Kernel/ClassDescription.class.st
@@ -747,9 +747,10 @@ ClassDescription >> hasSlot: aSlot [
 
 { #category : #slots }
 ClassDescription >> hasSlotNamed: aString [
-	"Return true whether the receiver defines an instance variable named aString."
+	"Return true whether the receiver defines an instance variable named aString.
+	this includs non-visible slots"
 
-	^ self allSlots anySatisfy: [:slot | slot name = aString]
+	^ self classLayout hasSlotNamed: aString
 ]
 
 { #category : #'instance variables' }

diff --git a/src/Slot-Core/AbstractLayout.class.st b/src/Slot-Core/AbstractLayout.class.st
@@ -73,6 +73,8 @@ AbstractLayout >> hasSlot: aSlot [
 
 { #category : #api }
 AbstractLayout >> hasSlotNamed: aString [
+	"Return true whether the receiver defines an instance variable named aString.
+	this includs non-visible slots"
 	^self allSlots anySatisfy: [:slot | slot name = aString  ]
 ]