Test: performing undo on refactoring that has more changes than the U…

…ndoSize

src/Refactoring-Changes-Tests/RBRefactoringChangeManagerPerformChangesTest.class.st

@@ -11,7 +11,7 @@ Class {
 { #category : 'instance creation' }
 RBRefactoringChangeManagerPerformChangesTest >> listOfMockChangesWithSize: aNumber [
 
-	^ (1 to: aNumber) collect: [ :i | RBRefactoringChangeMock new ]
+	^ (1 to: aNumber) collect: [ :i | RBRefactoringChangeMock new name: i asString ]
 ]
 
 { #category : 'instance creation' }
@@ -39,3 +39,27 @@ RBRefactoringChangeManagerPerformChangesTest >> testPerformChanges [
 
 	self deny: manager hasUndoableOperations
 ]
+
+{ #category : 'tests' }
+RBRefactoringChangeManagerPerformChangesTest >> testPerformChangesWhenChangesBiggerThanUndoSizeExpectCorrectChangesUndone [
+
+	| changes undoneChanges |
+	changes := self listOfMockChangesWithSize: manager class undoSize + 1.
+	manager performChanges: changes.
+
+	undoneChanges := manager undoLastRefactoring.
+
+	self assertCollection: undoneChanges first changes asArray equals: changes reversed asArray
+]
+
+{ #category : 'tests' }
+RBRefactoringChangeManagerPerformChangesTest >> testPerformChangesWhenChangesSmallerThanUndoSizeExpectCorrectChangesUndone [
+
+	| changes undoneChanges |
+	changes := self listOfMockChangesWithSize: 5.
+	manager performChanges: changes.
+
+	undoneChanges := manager undoLastRefactoring.
+
+	self assertCollection: undoneChanges first changes asArray equals: changes reversed asArray
+]

src/Refactoring-Changes-Tests/RBRefactoringChangeMock.class.st

@@ -49,6 +49,16 @@ RBRefactoringChangeMock >> one [
 	^ 1
 ]
 
+{ #category : 'printing' }
+RBRefactoringChangeMock >> printOn: aStream [
+	"Generate a string representation of the receiver based on its instance variables."
+
+	super printOn: aStream.
+	aStream
+		nextPutAll: ' name: ';
+		print: name
+]
+
 { #category : 'accessing' }
 RBRefactoringChangeMock >> renameChangesForClass: oldClassName to: newClassName [
 	"I'm a mock, I do nothing"

src/Refactoring-Changes/RBRefactoryChangeManager.class.st

@@ -248,7 +248,8 @@ RBRefactoryChangeManager >> undoLastRefactoring [
 	list := OrderedCollection new.
 	limit := manager lastUndoPointer .
 	1 to: limit do:[ :i | list add: manager undoChange ].
-	list do: [ :e | e execute ]
+	list do: [ :e | e execute ].
+	^ list
 	 ] asJob
 		title: 'Refactoring';
 		run]