Skip to content

Commit

Permalink
EpMonitor: Remove old code for subscribing to test announcer.
Browse files Browse the repository at this point in the history
By 2015, Epicea logged test runs and results. For example, when Test Runner run a suite, the log registered the successes and failures. At some point, that became a package extension, which is still in SmalltalkHub as "Epicea-SUnit". That package requires this code in EpMonitor that I propose to delete in this issue. Why? 1. it hasn't been used for years but it'd be easy to recover after delete; 2. AFAIR, the feedback I got was that logging test runs implied too much noise in the log of changes.

Fixes #7379.
  • Loading branch information
tinchodias committed Sep 25, 2020
1 parent a17c17a commit f691b29
Showing 1 changed file with 1 addition and 14 deletions.
15 changes: 1 addition & 14 deletions src/Epicea/EpMonitor.class.st
Expand Up @@ -9,7 +9,6 @@ Class {
#instVars : [
'systemAnnouncer',
'log',
'testAnnouncer',
'entryReferenceByEvent',
'jobAnnouncer',
'announcer',
Expand Down Expand Up @@ -349,7 +348,7 @@ EpMonitor >> disable [

self sessionStore flush.

{ systemAnnouncer. testAnnouncer. jobAnnouncer }
{ systemAnnouncer. jobAnnouncer }
do: [ :each | each ifNotNil: [ :a | a unsubscribe: self ] ].

self announceMonitorStateUpdated.
Expand All @@ -376,7 +375,6 @@ EpMonitor >> enable [

self isEnabled ifFalse: [
self subscribeToSystemAnnouncer.
self subscribeToTestAnnouncer.
self subscribeToJobAnnouncer. ].

self announceMonitorStateUpdated.
Expand Down Expand Up @@ -412,7 +410,6 @@ EpMonitor >> initializeWithLog: aLog [

log := aLog.
systemAnnouncer := SystemAnnouncer uniqueInstance.
testAnnouncer := TestCase historyAnnouncer.
jobAnnouncer := Job jobAnnouncer.

entryReferenceByEvent := IdentityDictionary new.
Expand Down Expand Up @@ -604,16 +601,6 @@ EpMonitor >> subscribeToSystemAnnouncer [

]

{ #category : #private }
EpMonitor >> subscribeToTestAnnouncer [
"Hook method. Overriden in EpiceaSUnit."
]

{ #category : #accessing }
EpMonitor >> testAnnouncer [
^ testAnnouncer
]

{ #category : #private }
EpMonitor >> time [
^ DateAndTime now
Expand Down

0 comments on commit f691b29

Please sign in to comment.