Skip to content

Commit

Permalink
Replace assert = in packages starting by M.
Browse files Browse the repository at this point in the history
Replace:

- assert: = by assert: equals:
- deny = by deny: equals:
- assert: == by assert: identicalTo:
- deny: == by deny: identicalTo:
  • Loading branch information
jecisc committed Nov 20, 2019
1 parent 66988bf commit fb4d9e9
Show file tree
Hide file tree
Showing 42 changed files with 1,727 additions and 1,898 deletions.
171 changes: 77 additions & 94 deletions src/Manifest-Tests/BuilderManifestTest.class.st
Expand Up @@ -40,54 +40,49 @@ BuilderManifestTest >> tearDown [

{ #category : #tests }
BuilderManifestTest >> testAddAllFalsePositive [

| manifestBuilder array|

array := {MFClassA. MFClassB }.
manifestBuilder := TheManifestBuilder of: MFClassA .
manifestBuilder installFalsePositiveOf: 'test' version: 0.

self deny: ((manifestBuilder falsePositiveOf: 'test' version: 0) anySatisfy: [:each| each = MFClassA]).
self deny: ((manifestBuilder falsePositiveOf: 'test' version: 0) anySatisfy: [:each| each = MFClassB]).

manifestBuilder addAllFalsePositive: array of: 'test' version: 0.

self assert: ((manifestBuilder falsePositiveOf: 'test' version: 0) anySatisfy: [:each| each = MFClassA]).
self assert: ((manifestBuilder falsePositiveOf: 'test' version: 0) anySatisfy: [:each| each = MFClassB]).

manifestBuilder addAllFalsePositive: array of: 'test' version: 0.

self assert: (manifestBuilder manifest ruletestV0FalsePositive size = 2).

manifestBuilder removeAllFalsePositive: array of: 'test' version: 0.

self deny: ((manifestBuilder falsePositiveOf: 'test' version: 0) anySatisfy: [:each| each = MFClassA]).
self deny: ((manifestBuilder falsePositiveOf: 'test' version: 0) anySatisfy: [:each| each = MFClassB]).

| manifestBuilder array |
array := {MFClassA . MFClassB}.
manifestBuilder := TheManifestBuilder of: MFClassA.
manifestBuilder installFalsePositiveOf: 'test' version: 0.

self deny: ((manifestBuilder falsePositiveOf: 'test' version: 0) anySatisfy: [ :each | each = MFClassA ]).
self deny: ((manifestBuilder falsePositiveOf: 'test' version: 0) anySatisfy: [ :each | each = MFClassB ]).

manifestBuilder addAllFalsePositive: array of: 'test' version: 0.

self assert: ((manifestBuilder falsePositiveOf: 'test' version: 0) anySatisfy: [ :each | each = MFClassA ]).
self assert: ((manifestBuilder falsePositiveOf: 'test' version: 0) anySatisfy: [ :each | each = MFClassB ]).

manifestBuilder addAllFalsePositive: array of: 'test' version: 0.

self assert: manifestBuilder manifest ruletestV0FalsePositive size equals: 2.

manifestBuilder removeAllFalsePositive: array of: 'test' version: 0.

self deny: ((manifestBuilder falsePositiveOf: 'test' version: 0) anySatisfy: [ :each | each = MFClassA ]).
self deny: ((manifestBuilder falsePositiveOf: 'test' version: 0) anySatisfy: [ :each | each = MFClassB ])

"manifestBuilder manifest class removeSelector: (manifestBuilder selectorFalsePositiveOf: 'test' version: 0)"
]

{ #category : #tests }
BuilderManifestTest >> testAddAllToDo [

| manifestBuilder array|

array := {MFClassA. MFClassB }.
manifestBuilder := TheManifestBuilder of: MFClassA .
manifestBuilder installToDoOf: 'test' version: 0.

self deny: ((manifestBuilder toDoOf: 'test' version: 0) anySatisfy: [:each| each = MFClassA]).
self deny: ((manifestBuilder toDoOf: 'test' version: 0) anySatisfy: [:each| each = MFClassB]).

manifestBuilder addAllToDo: array of: 'test' version: 0.

self assert: ((manifestBuilder toDoOf: 'test' version: 0) anySatisfy: [:each| each = MFClassA]).
self assert: ((manifestBuilder toDoOf: 'test' version: 0) anySatisfy: [:each| each = MFClassB]).

manifestBuilder addAllToDo: array of: 'test' version: 0.

self assert: (manifestBuilder manifest ruletestV0TODO size = 2).
| manifestBuilder array |
array := {MFClassA . MFClassB}.
manifestBuilder := TheManifestBuilder of: MFClassA.
manifestBuilder installToDoOf: 'test' version: 0.

self deny: ((manifestBuilder toDoOf: 'test' version: 0) anySatisfy: [ :each | each = MFClassA ]).
self deny: ((manifestBuilder toDoOf: 'test' version: 0) anySatisfy: [ :each | each = MFClassB ]).

manifestBuilder addAllToDo: array of: 'test' version: 0.

self assert: ((manifestBuilder toDoOf: 'test' version: 0) anySatisfy: [ :each | each = MFClassA ]).
self assert: ((manifestBuilder toDoOf: 'test' version: 0) anySatisfy: [ :each | each = MFClassB ]).

manifestBuilder addAllToDo: array of: 'test' version: 0.

self assert: manifestBuilder manifest ruletestV0TODO size equals: 2
]

{ #category : #tests }
Expand Down Expand Up @@ -183,37 +178,33 @@ BuilderManifestTest >> testAddToDo [
{ #category : #tests }
BuilderManifestTest >> testCleanUpFP [
| manifestBuilder |

manifestBuilder := TheManifestBuilder of: MFClassA. .
MFClassA compile: 'foo'.
manifestBuilder := TheManifestBuilder of: MFClassA.
MFClassA compile: 'foo'.
manifestBuilder installFalsePositiveOf: 'test' version: 0.
manifestBuilder addFalsePositive: (MFClassA>>#foo) of: 'test' version: 0.
self assert: (manifestBuilder containsFalsePositive: (MFClassA>>#foo) onRule: 'test' version: 0).
manifestBuilder addFalsePositive: MFClassA >> #foo of: 'test' version: 0.

self assert: (manifestBuilder containsFalsePositive: MFClassA >> #foo onRule: 'test' version: 0).

MFClassA removeSelector: #foo.
manifestBuilder cleanUp.

self assert: ((manifestBuilder falsePositiveOf: 'test' version: 0 ) size = 0) .

self assert: (manifestBuilder falsePositiveOf: 'test' version: 0) size equals: 0
]

{ #category : #tests }
BuilderManifestTest >> testCleanUpTD [
| manifestBuilder |

manifestBuilder := TheManifestBuilder of: MFClassA. .
MFClassA compile: 'foo'.
manifestBuilder := TheManifestBuilder of: MFClassA.
MFClassA compile: 'foo'.
manifestBuilder installToDoOf: 'test' version: 0.
manifestBuilder addToDo: (MFClassA>>#foo) of: 'test' version: 0.
self assert: (manifestBuilder containsToDo: (MFClassA>>#foo) onRule: 'test' version: 0).
manifestBuilder addToDo: MFClassA >> #foo of: 'test' version: 0.

self assert: (manifestBuilder containsToDo: MFClassA >> #foo onRule: 'test' version: 0).

MFClassA removeSelector: #foo.
manifestBuilder cleanUp.

self assert: ((manifestBuilder toDoOf: 'test' version: 0 ) size = 0) .

self assert: (manifestBuilder toDoOf: 'test' version: 0) size equals: 0
]

{ #category : #tests }
Expand Down Expand Up @@ -387,42 +378,34 @@ BuilderManifestTest >> testIsFalsePositive [

{ #category : #tests }
BuilderManifestTest >> testResetFalsePositive [

| manifestBuilder array|

array := {MFClassA. MFClassB }.
manifestBuilder := TheManifestBuilder of: MFClassA .
manifestBuilder installFalsePositiveOf: 'test' version: 0.

manifestBuilder addAllFalsePositive: array of: 'test' version: 0.

self assert: ((manifestBuilder falsePositiveOf: 'test' version: 0) anySatisfy: [:each| each = MFClassA]).
self assert: ((manifestBuilder falsePositiveOf: 'test' version: 0) anySatisfy: [:each| each = MFClassB]).

manifestBuilder resetFalsePositiveOf: 'test' version: 0.

self assert: (manifestBuilder manifest ruletestV0FalsePositive size = 0).


| manifestBuilder array |
array := {MFClassA . MFClassB}.
manifestBuilder := TheManifestBuilder of: MFClassA.
manifestBuilder installFalsePositiveOf: 'test' version: 0.

manifestBuilder addAllFalsePositive: array of: 'test' version: 0.

self assert: ((manifestBuilder falsePositiveOf: 'test' version: 0) anySatisfy: [ :each | each = MFClassA ]).
self assert: ((manifestBuilder falsePositiveOf: 'test' version: 0) anySatisfy: [ :each | each = MFClassB ]).

manifestBuilder resetFalsePositiveOf: 'test' version: 0.

self assert: manifestBuilder manifest ruletestV0FalsePositive size equals: 0
]

{ #category : #tests }
BuilderManifestTest >> testResetToDo [

| manifestBuilder array|

array := {MFClassA. MFClassB }.
manifestBuilder := TheManifestBuilder of: MFClassA .
manifestBuilder installToDoOf: 'test' version: 0.

manifestBuilder addAllToDo: array of: 'test' version: 0.

self assert: ((manifestBuilder toDoOf: 'test' version: 0) anySatisfy: [:each| each = MFClassA]).
self assert: ((manifestBuilder toDoOf: 'test' version: 0) anySatisfy: [:each| each = MFClassB]).

manifestBuilder resetToDoOf: 'test' version: 0.

self assert: (manifestBuilder manifest ruletestV0TODO size = 0).


| manifestBuilder array |
array := {MFClassA . MFClassB}.
manifestBuilder := TheManifestBuilder of: MFClassA.
manifestBuilder installToDoOf: 'test' version: 0.

manifestBuilder addAllToDo: array of: 'test' version: 0.

self assert: ((manifestBuilder toDoOf: 'test' version: 0) anySatisfy: [ :each | each = MFClassA ]).
self assert: ((manifestBuilder toDoOf: 'test' version: 0) anySatisfy: [ :each | each = MFClassB ]).

manifestBuilder resetToDoOf: 'test' version: 0.

self assert: manifestBuilder manifest ruletestV0TODO size equals: 0
]
16 changes: 6 additions & 10 deletions src/Manifest-Tests/SmalllintManifestCheckerTest.class.st
Expand Up @@ -54,22 +54,18 @@ SmalllintManifestCheckerTest >> tearDown [

{ #category : #tests }
SmalllintManifestCheckerTest >> testCriticsOf [

| rule critiques |
rule := ReRuleManager visibleRuleClasses collect: #new.
checker
checker
rule: rule;
environment: self package asEnvironment;
run.
run.

critiques := checker criticsOf: GRTemporaryNeitherReadNorWrittenRule new.

self assert: critiques size = 3.
self assert: (critiques anySatisfy: [ :each |
each sourceAnchor entity = (MFClassB>>#method3)]).
self assert: (critiques anySatisfy: [ :each |
each sourceAnchor entity = (MFClassA>>#method)]).

self assert: critiques size equals: 3.
self assert: (critiques anySatisfy: [ :each | each sourceAnchor entity = (MFClassB >> #method3) ]).
self assert: (critiques anySatisfy: [ :each | each sourceAnchor entity = (MFClassA >> #method) ])
]

{ #category : #tests }
Expand Down
Expand Up @@ -50,39 +50,37 @@ MetacelloCommonVersionNumberTestCase >> testAlphaNumericVersion4 [

{ #category : #'tests version increment/decrement' }
MetacelloCommonVersionNumberTestCase >> testIncrementDecrementVersion [
| version |
version := self defaultVersion1.
self assert: version incrementMajorVersion asString = '2.0.0'.
self assert: version decrementMajorVersion asString = '1.0.0'.
self assert: version incrementMinorVersion asString = '1.1.0'.
self assert: version decrementMinorVersion asString = '1.0.0'.
self assert: version incrementPatchVersion asString = '1.0.1'.
self assert: version decrementPatchVersion asString = '1.0.0'
| version |
version := self defaultVersion1.
self assert: version incrementMajorVersion asString equals: '2.0.0'.
self assert: version decrementMajorVersion asString equals: '1.0.0'.
self assert: version incrementMinorVersion asString equals: '1.1.0'.
self assert: version decrementMinorVersion asString equals: '1.0.0'.
self assert: version incrementPatchVersion asString equals: '1.0.1'.
self assert: version decrementPatchVersion asString equals: '1.0.0'
]

{ #category : #'tests version increment/decrement' }
MetacelloCommonVersionNumberTestCase >> testIncrementDecrementVersionNumber [
| version |
version := self defaultVersion1.
self assert: version incrementMinorVersionNumber asString = '1.0.1'.
self assert: version decrementMinorVersionNumber asString = '1.0.0'
| version |
version := self defaultVersion1.
self assert: version incrementMinorVersionNumber asString equals: '1.0.1'.
self assert: version decrementMinorVersionNumber asString equals: '1.0.0'
]

{ #category : #tests }
MetacelloCommonVersionNumberTestCase >> testVersion01 [

self assert: ((self versionClass fromString: '1.1.1') versionString = '1.1.1')
self assert: (self versionClass fromString: '1.1.1') versionString equals: '1.1.1'
]

{ #category : #tests }
MetacelloCommonVersionNumberTestCase >> testVersion02 [

| v1 v2 |
v1 := self versionClass fromString: '1.1.1'.
v2 := self versionClass fromString: '1.0.0'.
self assert: (v1 = v1).
self assert: (v2 = v2).
self assert: (v1 > v2)
self assert: v1 equals: v1.
self assert: v2 equals: v2.
self assert: v1 > v2
]

{ #category : #tests }
Expand All @@ -103,26 +101,20 @@ MetacelloCommonVersionNumberTestCase >> testVersion14 [

{ #category : #tests }
MetacelloCommonVersionNumberTestCase >> testVersion22 [

self assert: (MetacelloVersionNumber fromString: '3.0.0') collapseZeros size = 1.
self assert: (MetacelloVersionNumber fromString: '3.0.0') = (MetacelloVersionNumber fromString: '3.0').
self assert: (MetacelloVersionNumber fromString: '3.0') = (MetacelloVersionNumber fromString: '3.0.0').


self assert: (MetacelloVersionNumber fromString: '3.0.0') collapseZeros size equals: 1.
self assert: (MetacelloVersionNumber fromString: '3.0.0') equals: (MetacelloVersionNumber fromString: '3.0').
self assert: (MetacelloVersionNumber fromString: '3.0') equals: (MetacelloVersionNumber fromString: '3.0.0')
]

{ #category : #tests }
MetacelloCommonVersionNumberTestCase >> testVersion23 [

self assert: (MetacelloVersionNumber fromString: '3.0.0.-rc.1') = (MetacelloVersionNumber fromString: '3.0.0-rc.1').
self assert: (MetacelloVersionNumber fromString: '3.0.0.-rc.1') equals: (MetacelloVersionNumber fromString: '3.0.0-rc.1').
self assert: (MetacelloVersionNumber fromString: '3.0') > (MetacelloVersionNumber fromString: '3.0-rc.1').
self assert: (MetacelloVersionNumber fromString: '3') > (MetacelloVersionNumber fromString: '3-rc.1').
self assert: (MetacelloVersionNumber fromString: '3.-rc.1') = (MetacelloVersionNumber fromString: '3.0.0-rc.1').
self assert: (MetacelloVersionNumber fromString: '3.0.-rc.1') = (MetacelloVersionNumber fromString: '3.0.0-rc.1').
self assert: (MetacelloVersionNumber fromString: '3.-rc.1') equals: (MetacelloVersionNumber fromString: '3.0.0-rc.1').
self assert: (MetacelloVersionNumber fromString: '3.0.-rc.1') equals: (MetacelloVersionNumber fromString: '3.0.0-rc.1').
self assert: (MetacelloVersionNumber fromString: '3') > (MetacelloVersionNumber fromString: '3.0-rc.1').
self assert: (MetacelloVersionNumber fromString: '3.0') > (MetacelloVersionNumber fromString: '3.0.0-rc.1').


self assert: (MetacelloVersionNumber fromString: '3.0') > (MetacelloVersionNumber fromString: '3.0.0-rc.1')
]

{ #category : #tests }
Expand Down

0 comments on commit fb4d9e9

Please sign in to comment.