Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better user experience for final dot critique and cleaning #12431

Closed
astares opened this issue Jan 26, 2023 · 6 comments · Fixed by #12455
Closed

Better user experience for final dot critique and cleaning #12431

astares opened this issue Jan 26, 2023 · 6 comments · Fixed by #12455

Comments

@astares
Copy link
Member

astares commented Jan 26, 2023

By default we would like to remove unnecessary separators from method body to istay clean.

See
https://twitter.com/TorstenAstares/status/1609666189382254593
https://twitter.com/TorstenAstares/status/1609952076804628482
and #12387

This includes unnecessary and unwanted spaces, tabs but also final dots at the end of the method.

Despite the cleaning and the default in the Pharo standard image some users might nonetheless
want to continue with them for their own packages. They also might not want to be criticized for
their the final dots.

So we should increase the user experience by providing a setting where they can disable this
default in the settings browser like:

image

astares added a commit to astares/pharo that referenced this issue Jan 26, 2023
- two settings to ignore dots when criticizing and cleaning
- more tests
- but not finished yet
@MarcusDenker
Copy link
Member

one idea could be to split the rule into two: whitespace and dot.

For whitespace, I want to experiment then with an automation: accepting code should do the whitespace remove automatically.

@jordanmontt
Copy link
Member

I like the idea of splitting the rule into two rules: white spaces and dots :)

@astares
Copy link
Member Author

astares commented Jan 27, 2023

No need to split but just configure - as this is possible with the same code. Already working on it. Please stay patient.

And yes - cleaning on accept would also be nice. But step by step.

@MarcusDenker
Copy link
Member

What confuses me is that I alway get a message about a dot, but there is no dot. Yes, it says "or", but my brain can not hanle that.

For me a split would really improve the situation.

@astares
Copy link
Member Author

astares commented Jan 27, 2023

It's not finished yet ...

@astares
Copy link
Member Author

astares commented Jan 28, 2023

PR is in #12455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants