Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for .st/.cs files file-in was accidentally removed toghether with ChangeSet class #15933

Open
pavel-krivanek opened this issue Jan 8, 2024 · 6 comments

Comments

@pavel-krivanek
Copy link
Collaborator

Bug description
The Pharo 12 lost support for old-style source files (.st, .cs) and should probably be returned because the code support in the image still remains. See ChangeSet class>>#fileReaderServicesForFile:suffix: and other methods in the categorry that were removed.

@hernanmd
Copy link
Contributor

hernanmd commented Jan 8, 2024

Hi Pavel,
In Pharo 12 if you open the File Browser, select a .st file to file in, right-click and click on "Changelist browser" item, a new Changes Browser window will open. From there you can select the changes you want to file in.

Does that work for you?

@pavel-krivanek
Copy link
Collaborator Author

before, if you dropped a file into Pharo window, you had an option to directly file-in the content of the file ("Install into the image" option). The same for the context menu in the File browser.

@jecisc
Copy link
Member

jecisc commented Jan 8, 2024

It seems weird to me that to code dealing with importing .st files was in the change set.

I think we should add back the feature but in the code importer (or in the code adding the services if it is loaded later) without a dependency to the change sets.

@guillep
Copy link
Member

guillep commented Jan 8, 2024

Well, this should be managed by a more UI part right?
Either the Application or window (if spec). Or the "World"?

@guillep
Copy link
Member

guillep commented Jan 8, 2024

At least the registry.

@jecisc
Copy link
Member

jecisc commented Jan 8, 2024

This is managed by the <fileService> pragma. So maybe it should be with FileService?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants