Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No button to fileIn code from FileBrowser #16453

Closed
yannij opened this issue Apr 13, 2024 · 8 comments
Closed

No button to fileIn code from FileBrowser #16453

yannij opened this issue Apr 13, 2024 · 8 comments
Assignees
Labels

Comments

@yannij
Copy link

yannij commented Apr 13, 2024

Bug description
FileIn code using the FIleBrowser can no longer be done, because there is no button the initiate a fileIn

To Reproduce
Steps to reproduce the behavior:

  1. Go to System/FileBrowser menu to open a FIleBrowser
  2. Navigate to a .st file you have previously filed-out, and select it
  3. Notice there is no way to fileIn the file. In version 11, there was an Install button

Expected behavior
There should be a button labelled Install or FileIn

Screenshots
filebrowser-v11
filebrowser-v12

Version information:

  • OS: MacOSX
  • Version: 13.6.6 (22G630)
  • Pharo Version 12
@Ducasse
Copy link
Member

Ducasse commented Apr 15, 2024

thanks a lot

@Ducasse Ducasse added the To fix before release Issure to fix before the upcoming Pharo release label Apr 15, 2024
@estebanlm
Copy link
Member

@hernanmd this is for you :)

@jecisc
Copy link
Member

jecisc commented Apr 15, 2024

I think this got lost when we removed the change set browser. IIRC there was a file service in that package to manage the file in of code.

@jecisc
Copy link
Member

jecisc commented Apr 15, 2024

Related issue: #15933

@hernanmd
Copy link
Member

@hernanmd this is for you :)

In #16470
(please note since I'm on vacation, it may take me longer to respond)

@jecisc
Copy link
Member

jecisc commented Apr 16, 2024

Fixed

@jecisc jecisc closed this as completed Apr 16, 2024
@MarcusDenker MarcusDenker reopened this Apr 30, 2024
@MarcusDenker
Copy link
Member

I do not see the fileIn button when I select a .st file

@MarcusDenker MarcusDenker added Version: Pharo 12 Version: Pharo 13 Issue to fix in Pharo 13 and removed To fix before release Issure to fix before the upcoming Pharo release labels Apr 30, 2024
@MarcusDenker
Copy link
Member

Ah, we have a new issue:

#16453

I close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants