-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UFFI/TFFI call for WebBrowser with specific URL length adds strange characters to the URL #15980
Comments
The issue is in the FFI call. The WBWindowsWebBrowser is doing a call with String* which doesn't make sense in this context since it is not made to be written on. See doc on FFI for reference: |
@demarey Because as now UFFI seems to be more strict it is required to also have a type definiton for the first parameter (constant 0) shellExecute: lpOperation file: lpFile parameters: lpParameters directory: lpDirectory show: nShowCmd
^ self ffiCall: #(
FFIConstantHandle ShellExecuteA(
int 0, "Operation is not associated with a window"
String lpOperation,
String lpFile,
String lpParameters,
String lpDirectory,
int nShowCmd)) module: #shell32 |
Fix for: UFFI/TFFI call for WebBrowser with specific URL length adds strange characters to the URL #15980
…owser-with-specific-URL-length-adds-strange-characters-to-the-URL-P11 Fix for: UFFI/TFFI call for WebBrowser with specific URL length adds strange characters to the URL #15980
Bug description
Given a URL with a specific length to open in WebBrowser on Windows adds strange characters to the URL
To Reproduce
you will see that strange characters added to the URL location in the webbrowser like
Expected behavior
Expect the URL to stay the same as given and to correctly open on the web browser
Screenshots
![image](https://private-user-images.githubusercontent.com/5980033/297804389-e164799b-5b86-48bd-af11-7f5749107749.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAwODEzMjAsIm5iZiI6MTcyMDA4MTAyMCwicGF0aCI6Ii81OTgwMDMzLzI5NzgwNDM4OS1lMTY0Nzk5Yi01Yjg2LTQ4YmQtYWYxMS03ZjU3NDkxMDc3NDkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcwNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MDRUMDgxNzAwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWIxNzcxNTIwZGNjNjE0ZWVlMDk4OGZmNWFhYmMyNGIyMzVmZWI5MzA1NmQ1NjU4MmNmYzIwNjI5NDVlMjQyYyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.HGmwnNYl_cVJl7rA7Du5YffofvWpdY8qKHaSTYTm5ac)
Version information:
Additional context
Using that URL in DOS just opens the correct location
Might possibly be an issue of UFFI/TFFI
The text was updated successfully, but these errors were encountered: