Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AST: testIsClean and testHasNonLocalReturn failing #16153

Closed
MarcusDenker opened this issue Feb 13, 2024 · 2 comments · Fixed by #16159
Closed

AST: testIsClean and testHasNonLocalReturn failing #16153

MarcusDenker opened this issue Feb 13, 2024 · 2 comments · Fixed by #16159

Comments

@MarcusDenker
Copy link
Member

Bug description
AST related tests are failing.

Especially tests like #testHasNonLocalReturn and #testIsClean, which is not good....

 testHasNonLocalReturn – MacOSX64.AST.Core.Tests.RBBlockNodeTest
testIsClean – MacOSX64.AST.Core.Tests.RBBlockNodeTest
 testIsA – MacOSX64.AST.Core.Tests.RBParserTest
testIsUsedAsReturnValueWhenNodeIsLastInBlockExpectTrue – MacOSX64.AST.Core.Tests.RBProgramNodeTest
MarcusDenker added a commit to MarcusDenker/pharo that referenced this issue Feb 14, 2024
@MarcusDenker
add back #lastIsReturn to RBArrayNode
2a6fcab 
fixes pharo-project#16153 (but there are other failing tests not related to this)
@MarcusDenker MarcusDenker mentioned this issue Feb 14, 2024
Merged
@MarcusDenker MarcusDenker changed the title AST: testIsClean and testHasNonLocalReturn failing (and more) AST: testIsClean and testHasNonLocalReturn failing Feb 14, 2024
@MarcusDenker
Copy link
Member Author

There seem to be two problems: one related to #lastIsReturn and one to the improvement of some other RB code

The PR fixes the #lastIsReturn, after we see what still fails and I open a new issue for those

@MarcusDenker
Copy link
Member Author

I added #16160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

16153-AST-testIsClean-and-testHasNonLocalReturn-failing-and-more MarcusDenker/pharo
1 participant
@MarcusDenker