Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] RBRemoveDirectAccessToVariableTransformationTest is failing #16291

Closed
jecisc opened this issue Mar 12, 2024 · 3 comments
Closed

[CI] RBRemoveDirectAccessToVariableTransformationTest is failing #16291

jecisc opened this issue Mar 12, 2024 · 3 comments

Comments

@jecisc
Copy link
Member

jecisc commented Mar 12, 2024

There is currently a failing test linked to refactorings.

testClassVariable – MacOSX64.Refactoring.Transformations.Tests.RBRemoveDirectAccessToVariableTransformationTest

Got addUndo: aRefactoringChange   undo push: aRefactoringChange.  undo size > self class undoSize ifTrue: [ "Remove the element at the bottom of the stack"   undo removeLast ].  redo := OrderedCollection new instead of addUndo: aRefactoringChange   undo push: aRefactoringChange.  undo size > self class undoSize ifTrue: [ undo removeFirst ].  redo := OrderedCollection new.
Stacktrace
TestFailure
Got addUndo: aRefactoringChange
    undo push: aRefactoringChange.
    undo size > self class undoSize ifTrue: [ "Remove the element at the bottom of the stack"
        undo removeLast ].
    redo := OrderedCollection new instead of addUndo: aRefactoringChange
    undo push: aRefactoringChange.
    undo size > self class undoSize ifTrue: [ undo removeFirst ].
    redo := OrderedCollection new.
RBRemoveDirectAccessToVariableTransformationTest(TestAsserter)>>assert:description:resumable:
RBRemoveDirectAccessToVariableTransformationTest(TestAsserter)>>assert:description:
RBRemoveDirectAccessToVariableTransformationTest(TestAsserter)>>assert:equals:
RBRemoveDirectAccessToVariableTransformationTest>>testClassVariable
RBRemoveDirectAccessToVariableTransformationTest(TestCase)>>performTest

Maybe this is linked to recent changes of @carolahp ?

@carolahp
Copy link
Contributor

Hi @jecisc , you are right, by modifying addUndo: I broke the test.
I updated the test so it uses the updated method's body.
I am creating the PR where I will ask for your review

@carolahp
Copy link
Contributor

Here's the link to the PR

jecisc added a commit that referenced this issue Mar 12, 2024
…ToVariableTransformationTest-is-failing-

Fixing issue #16291 - RBRemoveDirectAccessToVariableTransformationTest is failing
@balsa-sarenac
Copy link
Member

Fixed with: #16293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants