Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small cleanup: put FFI_i386>>#newCallbackArgumentReaderForCallback:inContext: into "callbacks" like any other #16504

Closed
astares opened this issue Apr 21, 2024 · 0 comments · Fixed by #16505
Closed

Small cleanup: put FFI_i386>>#newCallbackArgumentReaderForCallback:inContext: into "callbacks" like any other #16504

astares opened this issue Apr 21, 2024 · 0 comments · Fixed by #16505
Labels
Easy To fix before release Issure to fix before the upcoming Pharo release Version: Pharo 12
Milestone
12.0.0

Comments

@astares
Copy link
Member

astares commented Apr 21, 2024 •
edited

The method "FFI_i386>>#newCallbackArgumentReaderForCallback:inContext:" should be in "callbacks"
protocol (like any other) - and not in "callback". I think its a typo.

Screenshot from 2024-04-21 23 30 18

This is annoying and wrong as typically the method category chooser suggests "callback" when you want "callbacks" for own FFI callbacks. It's easy to fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy To fix before release Issure to fix before the upcoming Pharo release Version: Pharo 12
Projects
None yet
Milestone
12.0.0
1 participant
@astares