Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Slots that use base slot #3038

Closed
MarcusDenker opened this issue Mar 28, 2019 · 0 comments
Closed

Simplify Slots that use base slot #3038

MarcusDenker opened this issue Mar 28, 2019 · 0 comments
Assignees
@MarcusDenker
Projects
First Class Variables (Slots)

Comments

@MarcusDenker
Copy link
Member

no shared hierarchy yet, but as a first step a simplification:

-> no need for #layOutChanged: as #installingIn: is send when the class is fully created
-> offset calculation simplifies.

TODO:

  • shared Hierarchy
  • tests for removing with instances present
  • add a slot higher in the hierarchy: how to move base slot up?
MarcusDenker added a commit to MarcusDenker/pharo that referenced this issue Mar 28, 2019
@MarcusDenker
fixes pharo-project#3038
1baaf24
@MarcusDenker MarcusDenker mentioned this issue Mar 28, 2019
Closed
@cdlm cdlm added the review label Mar 28, 2019
MarcusDenker added a commit to MarcusDenker/pharo that referenced this issue Mar 28, 2019
@MarcusDenker
fixes pharo-project#3038
c6da500
@MarcusDenker MarcusDenker mentioned this issue Mar 28, 2019
Merged
First Class Variables (Slots) automation moved this from In progress to Done Mar 29, 2019
@cdlm cdlm removed the review label Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarcusDenker MarcusDenker

Labels
None yet
Projects
First Class Variables (Slots)
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

3038-Simplify-Slots-that-use-base-slot MarcusDenker/pharo
2 participants
@cdlm @MarcusDenker