Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review ReflectivityExamples class packaging #4232

Closed
astares opened this issue Aug 7, 2019 · 2 comments · Fixed by #5066
Closed

Review ReflectivityExamples class packaging #4232

astares opened this issue Aug 7, 2019 · 2 comments · Fixed by #5066

Comments

@astares
Copy link
Member

astares commented Aug 7, 2019 •
edited

ReflectivityExamples class is currently packaged in "Reflectivity-Tests".
But it is not a test - it is an example class used in tests and other places

So would ReflectivityExamples class not be better packaged into existing package "Reflectivity-Examples" ?

Comments?
@MarcusDenker
Copy link
Member

Yes, this is a good idea.

@MarcusDenker
Copy link
Member

I had a look: these are code examples of pharo code to be used by tests.. I think the best would be to

  • rename it and document it
  • change the one user outside of tests to not use it
  • and let it in the test package.

I want to later remove it and use some shared "code example" class with the compiler.

MarcusDenker added a commit to MarcusDenker/pharo that referenced this issue Nov 6, 2019
@MarcusDenker
- copy the two examples to the CoverageDemo class
c09d179 
This way it does not need to reference any class from the tests and is self-contained

fixes pharo-project#4232
@MarcusDenker MarcusDenker mentioned this issue Nov 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

4232-Review-ReflectivityExamples-class-packaging MarcusDenker/pharo
2 participants
@MarcusDenker @astares