New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming a class when the message browser is open breaks #4268
Comments
This is because a ring method does not have the same api than a compile method and that isMetaSide is only defined on RG. Solution should probably be
|
Confirmed in release Pharo8.0-SNAPSHOT-64bit-278304f. |
MarcusDenker
added a commit
to MarcusDenker/pharo
that referenced
this issue
Oct 14, 2020
… Ring entities should be used) fixes pharo-project#6509 and pharo-project#4268
Fixed in the spec repository. Will be be merged in the image withe the next merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
handleClassRenamed: anAnnouncement
| items selectedIndex |
items := self messages
collect: [ :rgMethod |
| interestedClassName interestedClass |
interestedClassName := anAnnouncement oldName.
interestedClass := anAnnouncement classRenamed.
rgMethod isMetaSide
^^^^^^^^^^^^^^^^^^^^^^^^^
ifTrue: [ interestedClassName := interestedClassName , ' class'.
interestedClass := interestedClass classSide ].
rgMethod parentName = interestedClassName
ifTrue: [ (interestedClass >> rgMethod selector) asFullRingDefinition ]
ifFalse: [ rgMethod ] ].
selectedIndex := messageList selectedIndex.
self messages: items.
self setSelectedIndex: selectedIndex
The text was updated successfully, but these errors were encountered: