Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contex>>#tempNamed:put: needs to update the all the copied temps up to the definition #4782

Closed
MarcusDenker opened this issue Oct 1, 2019 · 1 comment · Fixed by #4783
Closed

Contex>>#tempNamed:put: needs to update the all the copied temps up to the definition #4782

MarcusDenker opened this issue Oct 1, 2019 · 1 comment · Fixed by #4783

Comments

@MarcusDenker
Copy link
Member

Copied temps are copied from the defining context into all the contexts.

If we now change the var in the debugger, it calls #tempNamed:put: on the context.

-> make sure to walk up the context to the definition context of the temp and set the value in the copy
@MarcusDenker
Copy link
Member Author

This used to be there but was lost as the implementation got too complex... now it is easy to put back

MarcusDenker added a commit to MarcusDenker/pharo that referenced this issue Oct 1, 2019
@MarcusDenker
Copied temps are copied from the defining context into all the contexts.
4c5dee5 
If we now change the var in the debugger, it calls #tempNamed:put: on the context.

-> make sure to walk up the context to the definition context of the temp and set the value in the copy

fixes pharo-project#4782
@MarcusDenker MarcusDenker mentioned this issue Oct 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@MarcusDenker