Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings -> Display Scale Factor changing #5779

Closed
David5i6 opened this issue Feb 27, 2020 · 4 comments · Fixed by #5889
Closed

Settings -> Display Scale Factor changing #5779

David5i6 opened this issue Feb 27, 2020 · 4 comments · Fixed by #5889

Comments

@David5i6
Copy link
Contributor

In the Menu "Settings" in Appearance the "Display scale Factor" is alive. It changes automatically.
This issue also happens with the "Fullscreen Margin" value.

Sometimes that happens magically when entering in the Settings, other times it happens after draggin the value selector and changing the value.

It happens on MacOSX with Pharo 8 and Pharo 9 images downloaded from the launcher and in Windows 10 an pharo 9 from git.

@David5i6
Copy link
Contributor Author

The problem is in the Slider, The examples of Spec and Spec2 has the same problem.

I don't know too much about Spec, Spec2 or morphic, but as far I can go debugging, the problem is in the Morphic adapter.
There is a method in the parant class that updates on mouse move but I'm not sure if it's safe to verride it or the side effects of made changes on those methods (or if the problem really relies on them).

@David5i6
Copy link
Contributor Author

Found the problen in Slider>>ScrollAbsolute, sending a pullrequest.

@Ducasse
Copy link
Member

Ducasse commented Mar 14, 2020

Thanks we will have a look.

@guillep
Copy link
Member

guillep commented Mar 14, 2020

I confirm the issue. Just passing the cursor over the slider causes it to move :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants