Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fileouting a setter save the same file than a getter in calypso #6391

Closed
Ducasse opened this issue May 23, 2020 · 3 comments
Closed

fileouting a setter save the same file than a getter in calypso #6391

Ducasse opened this issue May 23, 2020 · 3 comments

Comments

@Ducasse
Copy link
Member

Ducasse commented May 23, 2020

The two methods are stored in a file with the same name so .... this is quite annoying.
Because when you need to file out a method, it means that you need it.

@Ducasse Ducasse added this to the 9.0.0 milestone May 23, 2020
@Ducasse Ducasse added the Easy label May 23, 2020
@olekscode
Copy link
Member

I'm working on this one

@olekscode
Copy link
Member

The problem comes from here:

ClassDescription >> fileOutMethod: selector
	"Write source code of a single method on a file.  Make up a name for the file."
	
	| internalStream |
	internalStream := (String new: 1000) writeStream.
	self fileOutMethod: selector on: internalStream.
	CodeExporter writeSourceCodeFrom: internalStream baseName: (self name , '-' , (selector copyReplaceAll: ':' with: '')) isSt: true.

Specifically,

selector copyReplaceAll: ':' with: ''

I remove that statement because I think that colon is allowed in file names in all modern OS (I might be wrong about this, so let me know)

@Ducasse
Copy link
Member Author

Ducasse commented Nov 27, 2020

oleksandr : is not accepted on windows.
So could you replace it with DoubleDot?

Ducasse added a commit that referenced this issue Dec 15, 2020
…-the-same-file-than-a-getter-in-calypso

Fixed #6391. Filed out methods are now saved into files that have colons in their names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants