Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RB - Undo refactoring sometimes not only undo the last changes of refactoring #8103

Closed
Lin777 opened this issue Dec 14, 2020 · 1 comment · Fixed by #16285 · May be fixed by #15800
Closed

RB - Undo refactoring sometimes not only undo the last changes of refactoring #8103

Lin777 opened this issue Dec 14, 2020 · 1 comment · Fixed by #16285 · May be fixed by #15800
Assignees
@carolahp @Lin777
Projects
Refactoring Engine

Comments

@Lin777
Copy link
Contributor

Lin777 commented Dec 14, 2020

To replicate:

  • Create a class called ClassX with a #exampleMethod method.
  • Create superclass by refactoring.
  • Do Push Up #exampleMethod method.
  • Do Undo last refactoring.

So, undo refactoring undo push up changes and create superclass changes
@Ducasse Ducasse added the Later label Dec 14, 2020
@Ducasse Ducasse added this to Current Iteration in Refactoring Engine via automation Dec 14, 2020
@Lin777 Lin777 moved this from Current Iteration to In progress in Refactoring Engine Dec 21, 2020
@Lin777 Lin777 moved this from In progress to Current Iteration in Refactoring Engine Dec 21, 2020
@Lin777 Lin777 moved this from Current Iteration to In progress in Refactoring Engine Dec 30, 2020
@Lin777 Lin777 moved this from In progress to Current Iteration in Refactoring Engine Jan 4, 2021
@Lin777 Lin777 moved this from Current Iteration to In progress in Refactoring Engine Jan 7, 2021
@Lin777 Lin777 moved this from In progress to Current Iteration in Refactoring Engine Jan 11, 2021
@Ducasse Ducasse moved this from Current Iteration to For Later (kind of Backlog) in Refactoring Engine Jan 25, 2021
VincentBlondeau added a commit to lifeware-sa/pharo that referenced this issue Dec 15, 2023
@VincentBlondeau
RBRefactoryChangeManager uses a Stack to handle the undo collection. …
605bd19 
…The stack top is the first element but it is not correctly managed.

This could partially fix  pharo-project#8103
@VincentBlondeau VincentBlondeau mentioned this issue Dec 15, 2023
Open
@carolahp carolahp self-assigned this Feb 28, 2024
carolahp added a commit to carolahp/pharo that referenced this issue Mar 6, 2024
@carolahp
Fix for pharo-project#8103 plus tests for Refactoring Changes
916a368
@carolahp carolahp mentioned this issue Mar 6, 2024
Merged
Ducasse added a commit that referenced this issue Mar 10, 2024
@Ducasse
Merge pull request #16285 from carolahp/8103-RB---Undo-refactoring-so…
a0e865b 
…metimes-not-only-undo-the-last-changes-of-refactoring

Fixes issue: RB - Undo refactoring sometimes not only undo the last changes of refactoring #8103
@carolahp
Copy link
Contributor

I will close this issue since it was solved in PR#16285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carolahp carolahp

@Lin777 Lin777

Labels
None yet
Projects
Refactoring Engine
Status: DONE
Refactoring Engine
  
For Later (kind of Backlog)
Milestone
No milestone
4 participants
@MarcusDenker @Ducasse @carolahp @Lin777