Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context>>#quickStep us unused and strange #8158

Closed
MarcusDenker opened this issue Dec 21, 2020 · 0 comments · Fixed by #8159
Closed

Context>>#quickStep us unused and strange #8158

MarcusDenker opened this issue Dec 21, 2020 · 0 comments · Fixed by #8159
Labels
Type: Cleanup

Comments

@MarcusDenker
Copy link
Member

Describe the problem
Context>>#quickStep is not used. It is not clear what it does (and why it is needed).

A real problem is that the state of being in this "QuickStep mode" is modelled as a class variable. This means that two
instances of Context (e.g. two open debuggers using quicksStep) would interfere with each other.

I propose to remove the code
MarcusDenker added a commit to MarcusDenker/pharo that referenced this issue Dec 21, 2020
@MarcusDenker
Context>>#quickStep is not used. It is not clear what it does (and wh…
d846602 
…y it is needed).

A real problem is that the state of being in this "QuickStep mode" is modelled as a class variable. This means that two
instances of Context (e.g. two open debuggers using quicksStep) would interfere with each other.

this PR removes the code

fixes pharo-project#8158
@MarcusDenker MarcusDenker mentioned this issue Dec 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

8158-ContextquickStep-is-unused-and-strange MarcusDenker/pharo
1 participant
@MarcusDenker