Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate JapaneseEnvironment leftover methods #8753

Closed
astares opened this issue Mar 9, 2021 · 0 comments · Fixed by #8754
Closed

Deprecate JapaneseEnvironment leftover methods #8753

astares opened this issue Mar 9, 2021 · 0 comments · Fixed by #8754
Labels
Type: Cleanup

Comments

@astares
Copy link
Member

astares commented Mar 9, 2021

JapaneseEnvironment has been deprecated (by moving to Deprecated90) but a few methods in other classes related to it seem to be uncategorized. I guess there was a problem in proper packaging and they should also have been moved to Deprecated90

Concrete:

the method AbstractFont>>#scanMultibyteJapaneseCharactersFrom:to:in:with:rightX: is sent from a deprecated method

it is unclassified which seems to be a leftover from another refactoring done by @estebanlm in 2017

same for
-- CharacterScanner>>#isBreakableAt:in:in:
-- CharacterScanner>>#scanJapaneseCharactersFrom:to:in:rightX:
@astares astares changed the title Deprecate JapaneseEnvironment leftover methods #1453 Deprecate JapaneseEnvironment leftover methods Mar 9, 2021
astares added a commit to astares/pharo that referenced this issue Mar 9, 2021
@astares
Deprecate JapaneseEnvironment leftover methods
81d8ed4 
Fix pharo-project#8753
@astares astares mentioned this issue Mar 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate JapaneseEnvironment leftover methods astares/pharo
1 participant
@astares