10035 text anchors with morphs do not render in rubric #10225
Conversation
|
Hi @kasperosterbye , could you manage to write a test on this somehow? |
|
I'll try - it is not obvious how it should be done as the layout algorithm actually made room for the morph, it just did not include it in the final rendering. |
|
Thanks this is cool to have tests!!! |
|
I did manage to dream up something I think actually tests it. |
|
Thanks @kasperosterbye for the quick response, I'll take a look in the next two days :) |
|
If you get the chance to look it over @guillep I would really appreciate it. The change is fundamental to the next version of in-image rendering of Microdown. |
|
Yes, i'll check it after lunch during the sprint! |
|
I like the the tearDown solution - thanks. |
| @@ -59,6 +59,31 @@ RubEditingAreaTest >> setUp [ | |||
| area setTextWith: 'one two three four'. | |||
| ] | |||
|
|
|||
| { #category : #'tests - accessing selection' } | |||
There was a problem hiding this comment.
No dots after last expression at end of method necessary. There is nothing that should follow a tearDown in a tearDown method
There was a problem hiding this comment.
I know - they are not warned against, and when I edit a method they sometimes end up being left behind. Just like the extra spaces at the end of a line which are (were) inserted by the completion mechanism. It would be really useful to have an editor option to remove unnecessary dots and blanks at accept.
There was a problem hiding this comment.
Yes - it is already on my "cleanup keep/improve code quality level" TODO list
| RubEditingAreaTest >> tearDown [ | ||
|
|
||
| area delete. | ||
| super tearDown. |
There was a problem hiding this comment.
And an other dot at the end of the last statement. It was in your commit.
|
I am afraid my git and iceberg skills are lacking here. I do not know how to include your commit in my PR so I can remove the extra dots. |
|
I'm doing it quickly, I already have the environment ready :) |
kasperosterbye
deleted the
10035-TextAnchors-with-morphs-do-not-render-in-Rubric
branch
After a lot of poking around, the problem was that
RubAbstractTextAreasimply did not render TextAnchors if they contained a morph. This PR fixes it (within my understanding of Rubrics).