Enh/better expansion for non fluid #10759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Ducasse
commented
Jan 16, 2022
Ducasse
commented
- Fixing some glitches on the fluid class parser
- Fixing the DNU on oldPharoDefinition
- Add tests
- Does not introduce expansion on oldPharoDefinition for now.
… the correct messsage and it leads to two different selectors in different classes. + fixing the expansion on metaclass too. + fixed the tests Next check on ProtoObject check oldPharo... for the expansion.
|
Broken tests are related. |
|
Looks like the tests shortcut the double dispatch. :) |
|
Unrelated broken tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.