Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Spec1 #10818

Merged
merged 5 commits into from
Feb 1, 2022
Merged

Remove Spec1 #10818

merged 5 commits into from
Feb 1, 2022

Conversation

demarey
Copy link
Contributor

@demarey demarey commented Jan 28, 2022

Depends on PR #10816

@demarey demarey changed the title Remove Spec1 WIP: Remove Spec1 Jan 28, 2022
@MarcusDenker MarcusDenker linked an issue Jan 31, 2022 that may be closed by this pull request
Migrate presenters from Spec1 to Spec2 #10708
Closed
@demarey demarey changed the title WIP: Remove Spec1 Remove Spec1 Jan 31, 2022
@estebanlm estebanlm self-requested a review February 1, 2022 10:35
estebanlm
estebanlm requested changes Feb 1, 2022
View reviewed changes
Copy link
Member

@estebanlm estebanlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to remove the Spec1 packages from the repository too is not enough with not loading them :)

@MarcusDenker MarcusDenker merged commit 4270fc9 into pharo-project:Pharo10 Feb 1, 2022
@Ducasse
Copy link
Member

Ducasse commented Feb 1, 2022

super cooooooooooooool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebanlm estebanlm estebanlm approved these changes

Assignees
No one assigned
Labels
Status: Tests passed please review!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate presenters from Spec1 to Spec2
4 participants
@demarey @Ducasse @estebanlm @MarcusDenker