Increasing minimum size for Calypso browser #10838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demarey
reviewed
Feb 1, 2022
| @@ -123,7 +123,9 @@ Class { | |||
| 'navigationStarted', | |||
| 'plugins', | |||
| 'navigationEnvironment', | |||
| 'systemScope' | |||
| 'systemScope', | |||
| 'toolbars', | |||
There was a problem hiding this comment.
It looks like you have unused i.v.
There was a problem hiding this comment.
Oh you are right, I commited that by accident!
demarey
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New minimum size prevents widgets from hiding.
Note: In Calypso Browser, the middle toolbar (the one between the navigation views and the source code editor) constraints the minimum size of its container (which also contains the widgets).
To allow the browser to have a smaller size, the middle toolbar must be split into smaller toolbars, which are able to resize together with their container