Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserting variable breakpoint when the selected node is variable and the user double clicks left panel #10841

Conversation

carolahp
Copy link
Contributor

@carolahp carolahp commented Feb 1, 2022

Insert a VariableBreakpoint that breaks when the variable is accessed.
The problem of inserting breakpoints in pseudo-variables is not solved yet.

…eft panel, insert a VariableBreakpoint that breaks when the variable is accessed
@MarcusDenker
Copy link
Member

The question I have: why would setting a breakpoint on one variable set a breakpoint in all accesses?

I would never want that! if I set a breakpoint on a variable, I want to break on that one access.

@MarcusDenker
Copy link
Member

The "break on all read/write" should just be there as a menu, and maybe even only on the variable definition.

@carolahp
Copy link
Contributor Author

carolahp commented Feb 1, 2022

The "break on all read/write" should just be there as a menu, and maybe even only on the variable definition.

You are right, I just fixed the PR to:

  • Allow the insertion of normal breakpoints to variables
  • Remove the insertion of variable breakpoint on all accesses when the user double clicks the left panel

As a result, when a variable node is selected and the user double clicks the left panel, a normal breakpoint is inserted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants