Making inline refactoring's confirmation message more clear #11006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tesonep
requested changes
Mar 17, 2022
| refactoring setOption: #inlineExpression toUse: [ :ref :aString | self confirm: ('Do you want to inline the expression ''<1s>'' in the current method?' expandMacrosWith: aString) ] . | ||
| refactoring setOption: #inlineExpression toUse: [ :ref :aString | | ||
| (self confirm: ('Do you want to extract the expression ''<1s>'' into a variable in method ''', | ||
| ref sourceSelector,''' ?' expandMacrosWith: aString)) not ] . |
There was a problem hiding this comment.
Idem, should use expandMacros
There was a problem hiding this comment.
I just pushed a fix
| refactoring setOption: #inlineExpression toUse: [ :ref :aString | self confirm: ('Do you want to inline the expression ''<1s>'' in the current method?' expandMacrosWith: aString) ] . | ||
| refactoring setOption: #inlineExpression toUse: [ :ref :aString | | ||
| (self confirm: ('Do you want to extract the expression ''<1s>'' into a variable in method ''', | ||
| ref sourceSelector,''' ?' expandMacrosWith: aString)) not ] . |
There was a problem hiding this comment.
Idem, should use expandMacros
tesonep
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10994 .
This solution improves the confirmation message for user's clarity.
The refactoring is working well and the buttons 'yes' and 'no' do their job, but this is hard to see because the inline refactoring formats the code, making it hard for the user to see the difference between the two options