Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloseAllWindows #11408

Merged
merged 3 commits into from Jul 29, 2022
Merged

Conversation

RemiDufloer
Copy link
Contributor

We add a tool on taskBar menu to close all windows. When you click on the item an openModal window is created to check if you really want to do so

Capture d’écran 2022-06-24 à 16 56 59

Capture d’écran 2022-06-24 à 16 57 15

Capture d’écran 2022-06-24 à 16 57 29

Author : @RomainDeg and me

We add a tool on taskBar menu to close all windows. When you click on the item an openModal window is created to check if you really want to do so
We created for all items on the submenu close All of the taskBar, modal windows to confirm the action
@RemiDufloer
Copy link
Contributor Author

We added modal windows to confirm closing actions

@jgfoster
Copy link

  • It appears that we already have "Close all->unchanged windows". What is the added benefit of the new command? Is that it closes windows that have unsaved edits without warning you about the edits? That seems more dangerous than helpful!
  • It seems that it would be better to have "Close all" not repeated in the submenus.
  • I don't think we have close confirmations (unless you will lose unsaved edits) and I don't think the benefit is worth the extra confirmation.

@RemiDufloer
Copy link
Contributor Author

  • This new operation create the possibility for the users to close all window and for the window unchanged, a modal window is created, to ask the user if he wants to save or not the changes.
  • why ?
  • if you don't want extra confirmation maybe just create an option on settings for the beginners ?

@jgfoster
Copy link

@RemiDufloer, I don't feel very strongly about this, I was just reading through items with "please review!" and offering some feedback. Primarily, I don't see that there is much added value for the new menu option; but I do like consistency and it seems inconsistent to have two submenus start with "close all" and four not start with "close all".

Screen Shot 2022-07-13 at 11 22 37 AM

@guillep
Copy link
Member

guillep commented Jul 29, 2022

Hi all, I've fixed a bit the message so it avoids the redundant "Close".
I believe that a "close all windows" action is good, we can further iterate it later.

@guillep guillep merged commit 9d966dd into pharo-project:Pharo11 Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants