[Compiler] Stateless OpalCompiler #11482
Conversation
…API si changed to be #compile:/parse:/#evaluate: with source code as a parameter. #source: method is removed. - All users of compiler are adopted accordingly Environment parameter is moved from CompilationContext into OCSemanticScope as #targetEnvironmnet which is by default uses the environment of #targetClass. - it makes this #environment configuration really working. Previously it did nothing.
| failBlock: [^ self decompile ]; | ||
| class: self methodClass; | ||
| parse. | ||
| parse: self sourceCode. |
There was a problem hiding this comment.
Such move of #source: argument is the most of the changes here to remove the state from the compiler
| ^ self classLayout | ||
| resolveSlot: aName asSymbol | ||
| ifFound: [:var | var] | ||
| ifNone: [ self innerBindingOf: aName ] |
There was a problem hiding this comment.
The local lookup is introduced to find any variable defined in the class without the full environment lookup. It is required to allow the override of an #environment of a class during a compilation.
We should really review and unify all current lookup methods: #lookupVar:#lookupLocalVar:/#bindingOf:/#innerBindingOf:.
| { #category : #'options - settings API' } | ||
| CompilationContext class >> optionEmbeddAST [ | ||
| ^ self readDefaultOption: #optionEmbeddAST | ||
| ] |
There was a problem hiding this comment.
Here is new option #optionEmbeddAST
| @@ -488,7 +498,7 @@ CompilationContext >> noPattern: anObject [ | |||
| anObject ifTrue: [ | |||
| semanticScope := semanticScope asDoItScope. | |||
| "when we compile an expression, embedd sources, as the resulting method will never be installed" | |||
| self parseOptions: #(+ #optionEmbeddSources). | |||
| self parseOptions: #(+ #optionEmbeddSources + #optionEmbeddAST). | |||
There was a problem hiding this comment.
And #optionEmbeddAST is now default option for doIts
| ^self generate: methodTrailer | ||
| newMethod := self generate: methodTrailer. | ||
| self compilationContext optionEmbeddAST ifTrue: [ | ||
| newMethod propertyAt: #ast put: self ]. |
There was a problem hiding this comment.
And this is where optionEmbeddAST is used
| | environment method return | | ||
| environment := SystemDictionary new. | ||
| environment at: #MyClass put: Point copy. | ||
| (environment at: #MyClass) environment: environment. | ||
| environment at: #MyClass2 put: Association. |
There was a problem hiding this comment.
This test demonstrates the environment override. In the current image it does not work.
dionisiydk
changed the title
|
failing tests not related
|
|
What's the next step here? |
I am waiting @MarcusDenker review for this idea. Conflicts are resolved |
|
conflicts were badly fixed . I will revisit it. But it does not prevent the review |
|
The PR #13152 now adds some more state.. (see discussion) I need to think about this more (stateless compiler, CompilationContext is for sure now holding on to too much state...) |
|
I added the cleaning of the state in CompilationContext and OpalCompiler to #12883, I will think about that. |
|
So what is the status? I have the impression that the issue is not going to be integratable. |
With the recent changes to the compiler it is now clear that we can easily remove #source and #ast variables and reuse the compiler instance for parsing/compilation of multiple sources. This way we can get rid of CompilationContext moving all its state to the compiler. So that we will have logical reference from the method/AST to the producer compiler instance (currently it is the reference to the CompilationContext). Then many tools can be simplified by reusing a same compiler instance for own needs (highlighting for example).
Here PR performs main changes to the users of #compiler:
Versus old style:
The new style API was always there but it is now implemented without instance variables #source and #ast.
Most of the changes in PR is such a rewrite from old style to new one.
The deprecation of #source variable is required to get safe independent adoption of NewTools and Spec. After that the variables will be removed.
The inline of CompilerContext will be done in separate PR.
Environment parameter is moved from CompilationContext into OCSemanticScope as #targetEnvironment which uses the environment of #targetClass by default.
Introduce compilation option #optionEmbeddAST to remove #compileDoItFromAST method. Now #doIt compilation simply enables #optionEmbeddAST option (just as #optionEmbeddSources option) and a scope indirection is not needed anymore. See #generateMethod.