Attempt to fix scrolling behavior in RubAbstractTextArea & friends #11583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If enabled, sizes the morph width to match the maximum approximate line width
|
Failing test not related
|
|
Thank you @fmqa this fix is really helpful. |
|
Thanks for the test and feedback |
Ducasse
reviewed
Sep 4, 2022
| @@ -991,6 +992,10 @@ RubAbstractTextArea >> handleEdit: editBlock [ | |||
| "Ensure that changed areas get suitably redrawn" | |||
|
|
|||
| editBlock value. | |||
| "Fit to width on edit" | |||
| (self grow isNotNil & self grow) ifTrue: [ | |||
There was a problem hiding this comment.
I will integrate it but I would have preferred to have grow initialized to false and to avoid the isNil check.
|
I will integrate it now and it would be good to produce another one where grow is initialized to false and like that we avoid having a nil or true or false around and we can remove the isNotNil check. |
|
Thanks :)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #10666
Adds a flag that, if enabled, automatically resizes the text area horizontally so that its width equals the approximate point size of the longest text line in the editing pane. The flag is enabled by default for
RubScrolledTextMorph's textArea, thus alleviating issues with scrolling in Iceberg & Epicea's changeset viewers.