This adds an example and a test for Fluid Slot definitions #11786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… classes, the idea that we have to add all possible combinations of setters leads to a combinatorial explosion. We need to be able to do things like #slot => ExampleSlotWithFluidAPI value1: #testvalue1; value2: #testvalue2 if we ever want to be able to use this for anything non-trivial. This PR just adds an example on the level of Slots and a test that uses the class builder directly. We can not define classes using this, but editing is broken due to the Fluid Class Parser enforcing "#name => ClassName oneSelector: #state", that is, the Fuid Class Parser enforces a non-fluid API for Slots, oddly. (see pharo-project#6410)
demarey
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like with classes, the idea that we have to add all possible combinations of setters leads to a combinatorial explosion. We need to be able to do things like
if we ever want to be able to use this for anything non-trivial.
This PR just adds an example on the level of Slots and a test that uses the class builder directly.
We can define classes using this, but editing is broken due to the Fluid Class Parser enforcing "#name => ClassName oneSelector: #state", that is, the Fuid Class Parser enforces a non-fluid API for Slots, oddly. (see #6410 for an issue, see CDAbstractClassDefinitionParser>>#handleSlotNode: for where it breaks)