NumberParser accept and ignore underscore #12479
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposal is to extends number syntax to accept and ignore the underscore character
_
(ASCII 95).Many languages (including Python https://peps.python.org/pep-0515/ , Java https://docs.oracle.com/javase/7/docs/technotes/guides/language/underscores-literals.html or Ruby) accept some forms of numeric literal that ignore
_
.The idea is to permit long literals that are still readable, eg.
1_000_000_000
is easier for a human than100000000
especially since in the previous literal a zero is missing (I'm a tricky deceitful fellow).Usually, there is not a lot of constraint on the placement of
_
to accommodate various locales and usages or radix.However, duplicate or training
_
are usually rejected as syntax error.The PR just ignore any
_
without constrains. We might add them, or add them as rules for case that feel more being a syntax warning than a syntax error.