Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill syntax error debugger #12910

Merged
merged 3 commits into from Mar 15, 2023
Merged

Kill syntax error debugger #12910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4afab45
SyntaxErrorNotification stop launching syntaxErrorNotificationDefault…
privat Mar 6, 2023
f5b9d3f
kill syntaxErrorNotificationDefaultAction: since there is no more sender
privat Mar 6, 2023
6951821
kill tool SyntaxErrorDebugger
privat Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion src/BaselineOfIDE/BaselineOfIDE.class.st
View file
Open in desktop
Expand Up @@ -40,7 +40,6 @@ BaselineOfIDE >> additionalInitialization [
Smalltalk tools register: FileList as: #fileList.
Smalltalk tools register: Finder as: #finder.
Smalltalk tools register: ProcessBrowser as: #processBrowser.
Smalltalk tools register: SyntaxErrorDebugger as: #syntaxErrorDebugger.
Smalltalk tools register: TimeProfiler as: #timeProfiler.

(MorphicCoreUIManager classPool at: #UIProcess) ifNotNil: [ :proc | proc terminate ].
Expand Down
14 changes: 0 additions & 14 deletions src/CodeImportCommandLineHandlers/CommandLineUIManager.extension.st
View file
Open in desktop

This file was deleted.

4 changes: 3 additions & 1 deletion src/OpalCompiler-Core/SyntaxErrorNotification.class.st
View file
Open in desktop
Expand Up @@ -30,7 +30,9 @@ SyntaxErrorNotification class >> inClass: aClass withCode: codeString doitFlag:
{ #category : #exceptiondescription }
SyntaxErrorNotification >> defaultAction [

^ UIManager default syntaxErrorNotificationDefaultAction: self
"Notification are silently ignored by default.
Because SyntaxErrors are special (and not really resumable) it's better to force an error"
^ self unhandledErrorAction
]

{ #category : #accessing }
Expand Down
8 changes: 0 additions & 8 deletions src/Polymorph-Widgets/MorphicUIManager.class.st
View file
Open in desktop
Expand Up @@ -655,14 +655,6 @@ MorphicUIManager >> spawnNewProcess [
resume
]

{ #category : #'ui requests' }
MorphicUIManager >> syntaxErrorNotificationDefaultAction: anException [
"Handle a syntax error.
Note, if there is no #syntaxErrorDebugger registered, it will be silently ignored"
^Smalltalk tools using: #syntaxErrorDebugger do: [:tool |
tool open: (tool syntaxError: anException)]
]

{ #category : #'ui requests' }
MorphicUIManager >> systemNotificationDefaultAction: aNotification [

Expand Down
6 changes: 0 additions & 6 deletions src/Tool-Registry/PharoCommonTools.class.st
View file
Open in desktop
Expand Up @@ -288,12 +288,6 @@ PharoCommonTools >> register: anTool as: aNameSelector [
usedToolSet add: anTool
]

{ #category : #'registry access' }
PharoCommonTools >> syntaxErrorDebugger [

^ self toolNamed: #syntaxErrorDebugger
]

{ #category : #'registry access' }
PharoCommonTools >> testRunner [

Expand Down
305 changes: 0 additions & 305 deletions src/Tools/SyntaxErrorDebugger.class.st
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions src/UIManager/DummyUIManager.class.st
View file
Open in desktop
Expand Up @@ -151,15 +151,6 @@ DummyUIManager >> restoreDisplayAfter: aBlock [
self restoreDisplay
]

{ #category : #'default actions' }
DummyUIManager >> syntaxErrorNotificationDefaultAction: anException [
self traceCr: '*** SYNTAX ERROR ***'.
self traceCr: anException.
self
traceCr: (thisContext stack first: (20 min: thisContext stack size)).
anException return
]

{ #category : #'default actions' }
DummyUIManager >> traceCr: aString [

Expand Down
10 changes: 0 additions & 10 deletions src/UIManager/NonInteractiveUIManager.class.st
View file
Open in desktop
Expand Up @@ -190,13 +190,3 @@ NonInteractiveUIManager >> request: aStringOrText initialAnswer: defaultAnswer t
NonInteractiveUIManager >> requestPassword: queryString [
^self nonInteractiveWarning: 'Requesting Password'
]

{ #category : #'ui requests' }
NonInteractiveUIManager >> syntaxErrorNotificationDefaultAction: aSyntaxErrorNotification [

"display and log the syntax error"
super syntaxErrorNotificationDefaultAction: aSyntaxErrorNotification.

"in noninteractive mode simply quit"
^ self exitFailure
]