Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move weak dictionaries to new finalization #13212

Merged
merged 13 commits into from Apr 4, 2023

Conversation

guillep
Copy link
Member

@guillep guillep commented Mar 31, 2023

Weak dictionaries need to use the new finalization. Otherwise they are not being cleaned up unless explicitly called finalizeValues.

@jecisc
Copy link
Member

jecisc commented Mar 31, 2023

KeyNotFound: key #unresolved not found in Dictionary
Dictionary>>errorKeyNotFound:
[self errorKeyNotFound: key] in Dictionary>>at: in Block: [self errorKeyNotFound: key]
Dictionary>>at:ifAbsent:
Dictionary>>at:
EPCompilationRequestor>>bindingOf:
OCRequestorScope>>lookupVar:declare:
OCMethodScope(OCAbstractMethodScope)>>lookupVar:declare:
OCBlockScope(OCAbstractMethodScope)>>lookupVar:declare:
OCBlockScope(OCAbstractScope)>>lookupVar:
OCASTSemanticAnalyzer>>resolveVariableNode:
OCASTSemanticAnalyzer>>visitVariableNode:
UnresolvedVariable(Variable)>>acceptVisitor:node:
RBVariableNode>>acceptVisitor:
OCASTSemanticAnalyzer(RBProgramNodeVisitor)>>visitNode:
[ :each | self visitNode: each ] in OCASTSemanticAnalyzer(RBProgramNodeVisitor)>>visitMessageNode: in Block: [ :each | self visitNode: each ]
OrderedCollection>>do:
OCASTSemanticAnalyzer(RBProgramNodeVisitor)>>visitMessageNode:
RBMessageNode>>acceptVisitor:
OCASTSemanticAnalyzer(RBProgramNodeVisitor)>>visitNode:
[ :each | self visitNode: each ] in OCASTSemanticAnalyzer(RBProgramNodeVisitor)>>visitCascadeNode: in Block: [ :each | self visitNode: each ]
OrderedCollection>>do:
OCASTSemanticAnalyzer(RBProgramNodeVisitor)>>visitCascadeNode:
RBCascadeNode>>acceptVisitor:
OCASTSemanticAnalyzer(RBProgramNodeVisitor)>>visitNode:
[ :each | self visitNode: each ] in OCASTSemanticAnalyzer>>visitSequenceNode: in Block: [ :each | self visitNode: each ]
OrderedCollection>>do:
OCASTSemanticAnalyzer>>visitSequenceNode:
RBSequenceNode>>acceptVisitor:
OCASTSemanticAnalyzer(RBProgramNodeVisitor)>>visitNode:
OCASTSemanticAnalyzer>>visitBlockNode:

@Ducasse
Copy link
Member

Ducasse commented Apr 1, 2023

NewUndeclaredWarning: StTestDebuggerProvider>>buildDebuggerWithMissingClassContext (MissingClass is Undeclared)
KeyNotFound: key ASTCacheResetTest>>#annotatedMethod not found in ASTCache

@Ducasse
Copy link
Member

Ducasse commented Apr 1, 2023

Steven I added you because it looks like related to the debugger but I'm not sure.

@MarcusDenker MarcusDenker added the Status: Need more work The issue is nearly ready. Waiting some last bits. label Apr 3, 2023
@tesonep tesonep merged commit f0632f4 into pharo-project:Pharo11 Apr 4, 2023
1 of 2 checks passed
@tesonep tesonep deleted the enhance/weakDictionary branch April 4, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Need more work The issue is nearly ready. Waiting some last bits.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants