Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #13246 class comments can get lost when commiting code #13276

Merged
merged 6 commits into from Apr 4, 2023
Merged

Fix #13246 class comments can get lost when commiting code #13276

merged 6 commits into from Apr 4, 2023

Conversation

MarcusDenker
Copy link
Member

This fixes #13246

The real problem was that the class builder copied over the comment by copying the organisation.

  • fix it by doing that copy exlicitly
  • change a test to test for the comment not getting lost

The PR has some more improvements (to be continued in another PR)

  • use comment: and commen:stamp as the API
  • make sure to foward the API always to the instanceSide

TODO (later)

  • move API to Class and Trait and do the foward in MetaClass and meta trait explicitly
  • move ivar down to Class to avoid nil ivar in meta classes

@MarcusDenker MarcusDenker linked an issue Apr 4, 2023 that may be closed by this pull request
Class comments can get lost when commiting code #13246
Closed
@MarcusDenker MarcusDenker merged commit b6d7b7f into pharo-project:Pharo12 Apr 4, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@privat privat privat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Class comments can get lost when commiting code
2 participants
@MarcusDenker @privat