Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make protocol classification a setting #13615

Merged
merged 1 commit into from May 4, 2023
Merged

Make protocol classification a setting #13615

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
33 changes: 32 additions & 1 deletion src/Tool-Base/MethodClassifier.class.st
View file
Open in desktop
Expand Up @@ -10,6 +10,9 @@ Class {
#instVars : [
'protocol'
],
#classVars : [
'ShouldAlwaysClassify'
],
#classInstVars : [
'prefixMapping',
'keywordSuffixMapping',
Expand Down Expand Up @@ -165,6 +168,31 @@ MethodClassifier class >> prefixMapping [
prefixMapping]
]

{ #category : #accessing }
MethodClassifier class >> settingsOn: aBuilder [

<systemsettings>
(aBuilder setting: #shouldAlwaysClassify)
parent: #Calypso;
label: 'Automatically classify methods instead of using the selected protocol.';
default: false;
description: 'If true, the system browser will try to classify the methods using their name instead of using the currently selected protocol.';
target: self
]

{ #category : #accessing }
MethodClassifier class >> shouldAlwaysClassify [
"When enabled I'll try to classify all new methods in the code browser instead of using the selected protocol."

^ ShouldAlwaysClassify ifNil: [ ShouldAlwaysClassify := false ]
]

{ #category : #accessing }
MethodClassifier class >> shouldAlwaysClassify: anObject [

ShouldAlwaysClassify := anObject
]

{ #category : #classification }
MethodClassifier class >> suggestProtocolFor: aMethod [
^ (self new suggestProtocolFor: aMethod) ifNil: [ 'as yet unclassified' ]
Expand All @@ -179,9 +207,12 @@ MethodClassifier >> classify: aMethod [
{ #category : #classification }
MethodClassifier >> classify: aMethod fallbackProtocol: fallbackProtocol [
"fallback protocol is the protocol that was selected at method creation.
It will only be used if standard rules do not find a protocol for this method.
It will only be used if standard rules do not find a protocol for this method or if automatic classification is disabled.
It allows to have consistency for well known method names / prefixes."

"If the #shouldAlwaysClassify setting is off, we classify only if the given protocol is nil"
(self class shouldAlwaysClassify or: [ fallbackProtocol isNil ]) ifFalse: [ ^ aMethod protocol: fallbackProtocol ].

self suggestProtocolFor: aMethod.
protocol ifNotNil: [ ^ aMethod protocol: protocol ].
fallbackProtocol ifNotNil: [ aMethod protocol: fallbackProtocol ]
Expand Down