Completion: better update #13700
Merged
Completion: better update #13700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and stored completion token to see if an update is needed
|
Nice! I got this glitch today but I didn’t know how to reproduce it. |
…ot use wordAtCaret but use the correct completion token
MarcusDenker
added
the
Status: Need more work
|
tests failing in CoASTResultSetBuilderTest |
|
yeah. HeuristicCompletion is complex (and fragile), and the tests set up and use objects a little differently :( |
|
Windows is broken but tells us tests are fine.. (but they are not run)
|
privat
added
Status: Tests passed please review!
and removed
Status: Need more work
MarcusDenker
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The completion menu was updated on every key down (even unrelated, like a lone control key down) but the menuMorph was not refreshed (because refreshing cause the selection to be reset).
This caused graphical glitches when the menu content did not fit the initial completion menu area.
This PR store the current completion token into the completion context, so it becomes easy to see if the completion need an update and the menu need a refresh.
This should remove the last GUI issue with the completion menu (no issue number but I wanted to fix it anyway)
Feel free to open new ones :)