Disable Epicea debug mode in tests #13798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Epicea has a debug mode to catch errors. This is good for the users to get less noise when there is a bug (and Pharo been a big project, we have bugs for sure). But this is not good for the development of Pharo because we cannot know when an error happens. The best solution for me would be to enable the debug mode only for released versions. But we don't have thi information currently in the image and this would require to update the bootstrap to add the info in SystemVersion. Here I'm going for the second best thing I could think of: let the errors pass during the tests so that we can at least catch what the tests are unveiling. I�expect this PR to fail because marcus found some log producing errors. But at least we'll be able to detect them better and fix them before integrating this.
jecisc
added
the
Status: Need more work
MarcusDenker
added
Status: Tests passed please review!
and removed
Status: Need more work
MarcusDenker
approved these changes
May 31, 2023
|
We should turn on debug mode in general during development (in addition to have it always in during tests, which is done by this PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epicea has a debug mode to catch errors. This is good for the users to get less noise when there is a bug (and Pharo been a big project, we have bugs for sure). But this is not good for the development of Pharo because we cannot know when an error happens.
The best solution for me would be to enable the debug mode only for released versions. But we don't have thi information currently in the image and this would require to update the bootstrap to add the info in SystemVersion. Here I'm going for the second best thing I could think of: let the errors pass during the tests so that we can at least catch what the tests are unveiling.
I expect this PR to fail because Marcus found some log producing errors. But at least we'll be able to detect them better and fix them before integrating this.
When this will be mergeable, this will mean that no test will fail even with debug mode off. Fixes #13796