Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix System Browser scaling #13848

Merged

Conversation

Rinzwind
Copy link
Contributor

This pull request fixes some methods in ‘Calypso-Browser’ that used width and height constants without taking the display scale factor into account.

Screenshot of a System Browser after these changes:

The above screenshot was made after doing the snippets for ‘Retina display’ scaling from the comments in pull request #13767 (the message sent to SpFontStyle requires merging Spec pull request 1397):

WorldMorph displayScaleFactor: 2.
SourceCodeFonts setSourceCodeFonts: SourceCodeFonts sizeSmall * WorldMorph displayScaleFactor.
ToggleWithSymbolMenuItemShortcut
	classVarNamed: 'SymbolFont'
		put: (LogicalFont familyName: 'Lucida Grande' pointSize: 10 * WorldMorph displayScaleFactor);
	classVarNamed: 'SymbolTable' put: nil.
ThemeIcons current: ((ThemeIcons named: 'svgPack') in: [ :themeIcons |
	(themeIcons respondsTo: #loadIconsFromUrlUsingScale:) ifTrue: [
		themeIcons loadIconsFromUrlUsingScale: WorldMorph displayScaleFactor ] ];
	yourself).
World scaleFactor: WorldMorph displayScaleFactor reciprocal.
SpFontStyle applyDisplayScaleFactor: false.

@svenvc
Copy link
Contributor

svenvc commented May 29, 2023

Wow, this would be awesome. Thanks a lot for doing all this. Really great work!

@Ducasse
Copy link
Member

Ducasse commented May 29, 2023

Thanks Kris. This is really cool to have contribution like this because we are running after many fronts and yes sometimes we have too much to do :). So thanks!

@MarcusDenker MarcusDenker merged commit f77270a into pharo-project:Pharo12 May 30, 2023
1 of 2 checks passed
Rinzwind added a commit to Rinzwind/pharo that referenced this pull request Jul 23, 2023
@Rinzwind Rinzwind deleted the fix-system-browser-scaling branch August 29, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants