Fix doubleClick on tab and on text selection. #13906
Conversation
…d on text selection. Moved condition to LabelMorph.
|
Thanks for opening this pull request! Now continious integration (CI) will build Pharo with your change and run all tests. This might fail due to many reasons! Please check if your PR breaks the build or makes tests fail. Feel free to add comments to the PR. After this, before your PR can be merged it needs one or more reviews. Do not hesitate to ask people (on the Mailinglist or Discord) to help! When the CI shows no problems and there are positive reviews, your PR will be merged. |
|
Thanks this is cool to get your improvements. |
|
I do not know if this is related but testDoubleClickFromMorph – Unix64.Morphic.Tests.Event.MorphicEventHandlerTest is failing on mac and linux (windows did not run). |
| index := text size + 20. "an index out of bounds of string" | ||
| buttons := MouseButtonEvent redButton. | ||
| position := 20@100. | ||
| (area paragraph characterBlockForIndex: text size) surface leftCenter traceCr. |
There was a problem hiding this comment.
pay attention the traceCr should be removed.
MarcusDenker
added
the
Status: Need more work
MarcusDenker
removed
the
Status: Need more work
|
Thanks I will try the PR.... but it takes several min to open the repo :( so at least now I know that this is not a bug just super super slow. |
|
I cannot try it so I will integrate it and revert it if it does not work. |
|
Congrats on merging your first pull request! Do another one! We try to have a list of (relatively) easy issues here: https://github.com/orgs/pharo-project/projects/8.
|
This pull request addresses the following issues: #13577 and #13830