Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

21215-FileReference--nextVersion-should-works-on-folders-too #1433

Merged
merged 2 commits into from Jun 1, 2018
Merged

21215-FileReference--nextVersion-should-works-on-folders-too #1433

merged 2 commits into from Jun 1, 2018

Conversation

VincentBlondeau
Copy link
Contributor

jecisc
jecisc requested changes May 28, 2018
View reviewed changes
src/FileSystem-Core/FileReference.class.st
@@ -281,7 +281,7 @@ FileReference >> nextVersion [
parent := self parent.
nameWithoutExtension := self basename copyUpTo: $..

versionNumbers := parent files
versionNumbers := parent children
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cool to add a test.

@Ducasse Ducasse merged commit 6708399 into pharo-project:development Jun 1, 2018
@Ducasse
Copy link
Member

Ducasse commented Jun 1, 2018

Thanks Vincent and Cyril.
If you have time for a test it would be great. Now I integrate this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jecisc jecisc jecisc requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VincentBlondeau @Ducasse @jecisc