Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21990-isProbablyPrime-and-friends-should-not-refer-to-Transcript #1435

Merged
merged 1 commit into from May 28, 2018
Merged

21990-isProbablyPrime-and-friends-should-not-refer-to-Transcript #1435

merged 1 commit into from May 28, 2018

Conversation

Ducasse
Copy link
Member

@Ducasse Ducasse commented May 26, 2018

turning Transcript show: into comments. The two left on the class should be rethought. The code is broken.

Copy link
Member

@jecisc jecisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why comment them instead of removing?

@Ducasse
Copy link
Member Author

Ducasse commented May 27, 2018

Because I think that this can be useful to debug it. In fact I wanted to turn that into an internal stream writing and these places are the logical place to write to the stream.

@MarcusDenker
Copy link
Member

errors not related

@MarcusDenker MarcusDenker merged commit a1f7ee6 into pharo-project:development May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants