Gofer: Remove update of categories #14584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gofer>>updateCategories seems to do nothing in the end. It create a new organization definition but does not use it. It just call the post load on it with a nil parameter but the post load does nothing of this class. So let's see if we can remove it and have one less place dealing with categories. I also removed some related Metacello code dealing with this method
Gabriel-Darbord
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gofer>>updateCategories seems to do nothing in the end. It create a new organization definition but does not use it. It just call the post load on it with a nil parameter but the post load does nothing of this class.
So let's see if we can remove it and have one less place dealing with categories.
I also removed some related Metacello code dealing with this method