Going around on:fork: to debug announcement #14858
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not be considered for merging yet, but for review.
We're trying to make configurable the debugging of announcement, that use
on:fork:
to make unhandled errors non-blocking when happening during an announcement delivery.The problem in case of bugs is that we lose the stack that led to the unhandled error, and we're left with few information.
Here we use a metalink to replace the
on:fork:
with anon:do:
and see the full stack.We now have the stack back, it becomes blocking again, but can be (de)activated at will.
It works, but lots of questions:
on:fork:
directly and we then do not impact the system for users not interested by such debugging feature